Bug 239640 - www/miniflux: Update to 2.0.17 and pass conf as file instead of env
Summary: www/miniflux: Update to 2.0.17 and pass conf as file instead of env
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kirill Ponomarev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-04 05:03 UTC by Adam Weinberger
Modified: 2019-08-12 14:06 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (krion)


Attachments
miniflux conf as file (1.59 KB, patch)
2019-08-04 05:03 UTC, Adam Weinberger
no flags Details | Diff
miniflux conf as file + contrib (1.73 KB, patch)
2019-08-04 05:10 UTC, Adam Weinberger
no flags Details | Diff
2.0.17 (2.28 KB, patch)
2019-08-04 14:13 UTC, Adam Weinberger
no flags Details | Diff
2.0.17 + fixes (2.18 KB, patch)
2019-08-04 14:59 UTC, Adam Weinberger
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Weinberger freebsd_committer 2019-08-04 05:03:12 UTC
Created attachment 206267 [details]
miniflux conf as file

miniflux has supported passing the configuration as a file instead of environment for a while now. A poisoned file passed as environment could present an attack surface, so passing as a conf file is definitely a safer way to go.

This patch also fixes a few Makefile nits.
Comment 1 Adam Weinberger freebsd_committer 2019-08-04 05:10:43 UTC
Created attachment 206268 [details]
miniflux conf as file + contrib

Updating to patch to depend on postgresql-contrib to bring in hstore, which miniflux requires.
Comment 2 Adam Weinberger freebsd_committer 2019-08-04 14:13:35 UTC
Created attachment 206273 [details]
2.0.17

Also included: update to 2.0.17.
Comment 3 Adam Weinberger freebsd_committer 2019-08-04 14:59:50 UTC
Created attachment 206275 [details]
2.0.17 + fixes

contrib should be installed with server, not client.
Comment 4 Kirill Ponomarev freebsd_committer 2019-08-12 08:29:50 UTC
It installs databases/postgresql95-client as well, is it intended, I'm wonder why we need client in this case.
Comment 5 Adam Weinberger freebsd_committer 2019-08-12 13:37:51 UTC
Good question. Check out https://miniflux.app/docs/installation.html#database

New installations (and migrations from older versions) require the hstore extension, which is only available from the -contrib package.

It only installs it if the server option is enabled, because the client end doesn't need the hstore lib.
Comment 6 commit-hook freebsd_committer 2019-08-12 14:04:12 UTC
A commit references this bug:

Author: krion
Date: Mon Aug 12 14:04:08 UTC 2019
New revision: 508736
URL: https://svnweb.freebsd.org/changeset/ports/508736

Log:
  Upgrade to 2.0.17

  PR:		239640
  Submitted by:	adamw

Changes:
  head/www/miniflux/Makefile
  head/www/miniflux/distinfo
  head/www/miniflux/files/miniflux.in