Bug 239662 - [exp-run] print/harfbuzz drop cairo dependency
Summary: [exp-run] print/harfbuzz drop cairo dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Koop Mast
URL:
Keywords:
Depends on:
Blocks: 239156
  Show dependency treegraph
 
Reported: 2019-08-05 16:34 UTC by Koop Mast
Modified: 2019-08-24 09:21 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)
antoine: exp-run+


Attachments
Optionfy hbview, the cairo utility. (1.68 KB, patch)
2019-08-05 16:34 UTC, Koop Mast
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Koop Mast freebsd_committer 2019-08-05 16:34:10 UTC
Created attachment 206297 [details]
Optionfy hbview, the cairo utility.

Harfbuzz has the hbview utilitiy. This utility it the sole user of cairo, which pulls in a number of X libraries. This is undesired, for example the ImageMagick nox11 ports. Optionfy this utility with the default to off to don't have this dependancy anymore.

My own mini poudriere build didn't show any problems, but just to be sure nothing depends on it indirectly.
Comment 1 Koop Mast freebsd_committer 2019-08-05 16:34:47 UTC
Assign to portmgr@ for exp-run.
Comment 2 Ting-Wei Lan 2019-08-05 17:15:54 UTC
Can hb-view option be enabled by default? Small utilities provided by a library are sometimes useful to test its features or bugs. Given that nox11 is a non-default setup, I don't think we should change the default if nox11 is the only one needing the change.
Comment 3 Koop Mast freebsd_committer 2019-08-05 19:19:37 UTC
What your saying is true, but I rather not enable it by default. The hbview utility requires cairo, which in turn brings in X and mesa-libs. Which kind of just a lot for just this utility and harfbuzz doesn't require it itself.

I could turn it into a sub-package like was done with the harfbuzz-icu library, which should work for both our cases then.
Comment 4 Antoine Brodin freebsd_committer 2019-08-07 19:59:14 UTC
Exp-run looks fine,  but I think this doesn't change anything in the dependency chain (gkt20 depends on cairo through pango)
Comment 5 Ting-Wei Lan 2019-08-09 13:33:59 UTC
(In reply to Koop Mast from comment #3)
Yes, I think it is fine to move it to a separate package.
Comment 6 commit-hook freebsd_committer 2019-08-24 09:21:18 UTC
A commit references this bug:

Author: kwm
Date: Sat Aug 24 09:20:47 UTC 2019
New revision: 509716
URL: https://svnweb.freebsd.org/changeset/ports/509716

Log:
  Remove the hb-view utitilty from the main harfbuzz port and move it to it's
  own port. The hb-view utility is the only part of harfbuzz that requires
  cairo. So now harfbuzz doesn't pull in x11 libraries or mesa via cairo,this
  is usefull for ports that want to use harfbuzz but don't use or want x11.

  Add license

  Exp-run by:	antoine@
  PR: 		239662

Changes:
  head/print/Makefile
  head/print/harfbuzz/Makefile
  head/print/harfbuzz/pkg-plist
  head/print/harfbuzz-bh-view/
  head/print/harfbuzz-bh-view/Makefile
  head/print/harfbuzz-bh-view/pkg-plist
  head/print/harfbuzz-icu/Makefile