Bug 239737 - factor out hardcoding of "clangXYZ" in devel/flang
Summary: factor out hardcoding of "clangXYZ" in devel/flang
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Johannes M Dieterich
URL:
Keywords:
Depends on:
Blocks: 239736
  Show dependency treegraph
 
Reported: 2019-08-09 10:39 UTC by Mark Linimon
Modified: 2019-08-09 10:47 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (jmd)


Attachments
patch to devel/flang/Makefile (1.08 KB, patch)
2019-08-09 10:39 UTC, Mark Linimon
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Linimon freebsd_committer freebsd_triage 2019-08-09 10:39:32 UTC
Created attachment 206389 [details]
patch to devel/flang/Makefile

There are a number of places in the ports tree where the string "clang<version" is called out.  When doing the work to identify stale versions of clang tree-wide, these instances cause extra work.

Refactor this usage into LLVM_VER.

Note: this refactoring causes portlint to complain but IMHO this complication is worth tolerating to help ease maintainability.

Tested on: amd64.