Bug 239806 - pkgbase: Unset dependencies in some pkgbase packages
Summary: pkgbase: Unset dependencies in some pkgbase packages
Status: New
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-bugs mailing list
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-08-12 19:23 UTC by Martin
Modified: 2019-08-13 11:25 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin 2019-08-12 19:23:53 UTC
I am trying to visualize the dependencies of the pkgbase packages.
To produce the dot file for use with graphviz, i used a shell script greping
and seding the ucl files in the worldstage directory (see below). After some
fiddling i got a dot file graphviz could work with.

You can create one by your self, running the script and using the resulting
output in a online graphviz tool like http://www.webgraphviz.com/ or 
https://stamm-wilbrandt.de/GraphvizFiddle/# 

I will describe some ascpects of the resulting diagramm.

- the biggest node is the runtime package, a lot of packages depend on it.

- runtime itself depends only on the clibs package.

- clibs has dependent packages:
  clibs-debug, clibs-development, clibs-lib32, clibs-lib32-debug,
  clibs-lib32-development, clibs-lib32-profile, clibs-profile

- some packages depend on runtime, as mentioned, and have some
  dependent packages, e.g
  -> ssh depends on runtime
  -> these packages depend on the ssh packages:
     ssh-debug, ssh-development, ssh-lib32, ssh-lib32-debug,
	 ssh-lib32-development, ssh-lib32-profile, ssh-profile

- there are other packages which depend on runtime, but the "subpackages"
  do not depend on the package itself, e.g
  -> jail depends on runtime
  -> these packages depend also on runtime instead of jail:
     jail-debug, jail-development, jail-lib32, jail-lib32-debug,
     jail-lib32-development

- there are a LOT of packages which are standalone in the diagramm, e.g
  sendmail, the dependent packages sendmail-debug, sendmail-development,
  sendmail-lib32, sendmail-lib32-debug, sendmail-lib32-development,
  sendmail-lib32-profile, sendmail-profile are standalone as well.

- there is a mixture of the above, for example the runtime has dependent 
  packages as mentioned above and these standalone packages:
  runtime-lib32-debug, runtime-lib32-development, runtime-lib32-profile


as far as i can see, the dependencies are defined in the script
/usr/src/release/packages/generate-ucl.sh. In there, some names are
hardcoded, like "runtime", "runtime_*", "jail_*". Others are handled as
wildcards, like "*_lib32", "*_lib32_development", "*_lib32_debug", ...
which often do not depend on their "root" package. While the "named"
packages have their own ucl file, these wildcard packages are using
the template.ucl file, which does not contain the "deps:" attribute.

 
Script to create the graphviz dot file:
---8<---8<---8<---8<---8<---8<---8<---8<---8<

#!/bin/sh

echo "digraph pkgdeps {"
echo "    graph [center=0 rankdir=TD ];"

(
    for PKG in /usr/obj/usr/src/amd64.amd64/worldstage/*.ucl
    {
        PKG_NAME=${PKG##*/}
        PKG_DEPS=$(grep -h -A 1 deps ${PKG} | tail -n 1 | sed -e 's/^[ \t]*//' -e 's/FreeBSD-//g' -e 's/"//g' -e 's/: {//g')
        if [ ! ${PKG_DEPS} = "" ]; then
            echo "    \"${PKG_NAME%.ucl}\" -> \"${PKG_DEPS}\";"
        else
            echo "    \"${PKG_NAME%.ucl}\";"
        fi
    }
) | sort

echo "}"

--->8--->8--->8--->8--->8--->8--->8--->8--->8


--
Martin
Comment 1 Martin 2019-08-12 19:25:02 UTC
After adding this patch to /usr/src/release/packages/template.ucl

--- template.ucl_       2019-06-02 09:09:55.109358000 +0200
+++ template.ucl        2019-08-04 17:40:34.305308000 +0200
@@ -15,3 +15,9 @@
 desc = <<EOD
 %DESC%
 EOD
+deps: {
+    FreeBSD-%PKGDEPS%: {
+        origin: "base",
+        version: "%VERSION%"
+    }
+}

Almost all libraries are now depending on runtime, except:
- liby
- libpmcstat
- libpam
- libifconfig
the "subpackages", e.g *-development, *-profile, however are depending
on their root package. For example:
liby-devlopment -> liby
liby-profile    -> liby
etc.

Also, the clibs subpackages clibs-profile, clibs-development,...
are still standalone.

i rebuilt my pkgbase repo with "make -j4 packages", this finished
without error and a created jail with these packages startet without problem.

--
Martin