Created attachment 206650 [details]
add nginx conf example, handle all config files as samples.

ping

Comment 3 Daniel Engberg 2020-03-16 12:31:30 UTC

I think the general policy is not to accept new ports without a maintainer

Comment 4 Li-Wen Hsu 2020-07-02 04:28:42 UTC

(In reply to rozhuk.im from comment #2)
Do you want to be the maintainer of this port?

(In reply to Li-Wen Hsu from comment #4)

Yes, I use it :)

Comment 6 Li-Wen Hsu 2020-07-02 13:01:24 UTC

Created attachment 216139 [details]
rutorrent-3.10

I've done some modifications:

- Update to 3.10 (release)
- Fix include (second bsd.port.mk should be bsd.port.post.mk)
- Put submitter in MAINTAINER
- Generate patch with `make makepatch`

But it seems still have some issues:

- rutorent.conf is not in the ${FILESDIR}
- Having those permission settings is dangerous:
  @${CHMOD} -R 0777 ${STAGEDIR}${WWWDIR}/share
  @${CHMOD} 0644 ${STAGEDIR}${WWWDIR}/share/.htaccess
  Is it possible to change them? And ${CHMOD} can be replaced by `@(owner,group,mode)` in pkg-plist.

Can you check them and create a new patch based on this?
Also, please do these tests if possible:
- set `DEVELOPER=yes` in /etc/make.conf and do make again
- if possible, please test it in the poudriere.

Thanks for submitting this port!

(In reply to Li-Wen Hsu from comment #6)

Thanks, I will look into in next days.


> @${CHMOD} -R 0777 ${STAGEDIR}${WWWDIR}/share

must be writable for web UI process or you can not save any settings and probably some thing will not work.


> @${CHMOD} 0644 ${STAGEDIR}${WWWDIR}/share/.htaccess

but why this insecure?


> And ${CHMOD} can be replaced by `@(owner,group,mode)` in pkg-plist

This port generates pkg-plist on fly, easy to keep ${CHMOD} at "prepare" stage than patching with sed pkg-plist while it generating.

Comment 8 Kubilay Kocak 2020-07-03 04:08:59 UTC

@Li-Wen Can you self-assign this issue since you're providing patches to it. Will reduce noise on the lists, and improve SNR.

Also: "ruTorrent is a " needs removing from COMMENT

Comment 9 Daniel Engberg 2021-03-18 14:19:27 UTC

Any interest in this or can we close it?

I am use this, and prefer to upstream it to ports.

Comment 11 Li-Wen Hsu 2021-03-18 16:30:56 UTC

(In reply to rozhuk.im from comment #10)
Happy to help, and can you help create a new patch?

For mode 0777 ${STAGEDIR}${WWWDIR}/share, I suggest we at least have a pkg-message to warn about it, or we can even tell people to change that on their own.

Created attachment 231419 [details]
patch

Please restore the _cloudflare plugin. It's apparently required for scrapers that make external search plugins work.

Comment 14 Nuno Teixeira 2024-11-04 11:23:43 UTC

Hello,

My first question is:

What port should be responsable for using/adding a rc script?

My question is because a regular rtorrent user will use its TUI to work with and a rc script will not make sense.

Let's see some comments like:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256694#c1
and
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256694#c3

Comment 15 Nuno Teixeira 2024-11-08 08:15:18 UTC

(In reply to Nuno Teixeira from comment #14)

Upstream stable release is at 4.3.9 and 5.1 is at beta 4.
Can updated patches be submitted?

Thanks

Comment 16 Nuno Teixeira 2024-11-12 08:40:26 UTC

Friendly PING

Created attachment 255183 [details]
4.3.9.hotfix

Comment 18 Nuno Teixeira 2024-11-15 08:20:26 UTC

(In reply to Ivan Rozhuk from comment #17)

Something wrong with uploaded patch. Could you take a look?

Created attachment 255191 [details]
4.3.9.hotfix