Bug 240053 - www/vdradmin-am: Add missing dependency
Summary: www/vdradmin-am: Add missing dependency
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Kubilay Kocak
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2019-08-23 08:25 UTC by Matthias Pfaller
Modified: 2019-08-23 13:33 UTC (History)
1 user (show)

See Also:
koobs: maintainer-feedback? (mat)
koobs: merge-quarterly?


Attachments
Patch to add missing dependency (489 bytes, text/plain)
2019-08-23 08:25 UTC, Matthias Pfaller
koobs: maintainer-approval+
Details
http://beefy6.nyi.freebsd.org/data/120amd64-default/508353/logs/vdradmin-am-3.6.10.log (22.79 KB, text/plain)
2019-08-23 12:19 UTC, Kubilay Kocak
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Pfaller 2019-08-23 08:25:40 UTC
Created attachment 206818 [details]
Patch to add missing dependency

When building with sync I noticed, that www/p5-CGI is missing in the dependency list. The attached patch fixes this.

Matthias
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2019-08-23 10:07:37 UTC
Thank you for the report and patch Matthias.

What were the symptoms of the missing dependency? If it was certain output during port build/packaging, please include the output as an attachment
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2019-08-23 10:08:36 UTC
Comment on attachment 206818 [details]
Patch to add missing dependency

Approved by: portmgr (blanket: unmaintained port)

Pending QA

Note: Patch may require PORTREVISION bump
Comment 3 Matthias Pfaller 2019-08-23 11:17:11 UTC
(In reply to Kubilay Kocak from comment #1)
I no longer have the log. The synth watchdog would hit because during the installation phase vdradmin-am's install script would ask about installing the CGI module. And without input it would just hang forever.
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2019-08-23 11:19:28 UTC
(In reply to Matthias Pfaller from comment #3)

Thanks for the follow-up Matthias

So, that sounds like a build or install (stage)stage failure during package creation, rather than a runtime failure after package installation, is that right?

Can it currently be reproduced with synth/poudriere with the present port version?
Comment 5 Matthias Pfaller 2019-08-23 12:13:29 UTC
(In reply to Kubilay Kocak from comment #4)
I just rerun a build with the original Makefile. The error is generated during the staging phase.

--------------------------------------------------------------------------------
--  Phase: stage
--------------------------------------------------------------------------------
===>  Staging for vdradmin-am-3.6.10
===>   Generating temporary packing list
===> Creating groups.
===> Creating users
/bin/mkdir -p /construction/xports/www/vdradmin-am/work/stage/usr/local/etc/vdradmin-am
install  -m 0644 /xports/www/vdradmin-am/files/vdradmind.conf /construction/xports/www/vdradmin-am/work/stage/usr/local/etc/vdradmin-am/vdradmind.conf.sample
/bin/mkdir -p  /construction/xports/www/vdradmin-am/work/stage/var/cache/vdradmin-am  /construction/xports/www/vdradmin-am/work/stage/var/log/vdradmin-am /construction/xports/www/vdradmin-am/work/stage/var/run/vdradmin-am

********* Installing VDRAdmin-AM *************


*** Required ***
Checking for Perl module locale...  found
Checking for Perl module Template...  found
Checking for Perl module Template::Plugin::JavaScript...  found
Checking for Perl module CGI...  MISSING
Do you want to install CGI? [y/N]###  Watchdog killed runaway process!  (no activity for 34 minutes)  ###



--------------------------------------------------
--  Termination
--------------------------------------------------
Finished: Friday, 23 AUG 2019 at 11:36:19 UTC
Duration: 00:35:07
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2019-08-23 12:19:43 UTC
Created attachment 206822 [details]
http://beefy6.nyi.freebsd.org/data/120amd64-default/508353/logs/vdradmin-am-3.6.10.log

(In reply to Matthias Pfaller from comment #5)

Nice, thank you.

What's interesting is that vdradmin's build on the official package building cluster contains the same MISSING line, but doesn't fail to install (stage)
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2019-08-23 12:21:18 UTC
So it seems like its the interactive prompt "Do you want to install CGI? [y/N]" that's causing the build to ultimately fail (timeout), rather than the missing dependency.

Is it clear/apparent what the missing dependency actually changes in the build, either in terms of functional changes, feature support, or files installed?
Comment 8 Matthias Pfaller 2019-08-23 12:24:21 UTC
(In reply to Kubilay Kocak from comment #7)
Maybe its different with poudriere (if that's what's used in the building cluster) and the script gets /dev/null as input?
Comment 9 Kubilay Kocak freebsd_committer freebsd_triage 2019-08-23 12:25:17 UTC
Does starting vdramind without CGI module installed result in the same error as these Debian or Gentoo bugs:

 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=863043
 https://bugs.gentoo.org/show_bug.cgi?id=593506
Comment 10 Kubilay Kocak freebsd_committer freebsd_triage 2019-08-23 12:26:25 UTC
(In reply to Matthias Pfaller from comment #8)

Possibly, we just need confirmation that the package is indeed broken (either, build, packaging or at runtime), and in what manner, in order to verify the change

I'm guessing it is (given the Debian / Gentoo bugs), but independent confirmation would be great for this issue
Comment 11 Matthias Pfaller 2019-08-23 12:31:15 UTC
(In reply to Kubilay Kocak from comment #10)
bash# pkg delete p5-CGI
bash# service vdradmind start
Starting vdradmind.
Can't locate CGI.pm in @INC (you may need to install the CGI module) (@INC contains: /usr/local/bin/lib/ /usr/local/share/vdradmin-am/lib /usr/local/lib/perl5/site_perl/mach/5.28 /usr/local/lib/perl5/site_perl /usr/local/lib/perl5/5.28/mach /usr/local/lib/perl5/5.28) at /usr/local/bin/vdradmind line 64.
BEGIN failed--compilation aborted at /usr/local/bin/vdradmind line 64.
/usr/local/etc/rc.d/vdradmind: WARNING: failed to start vdradmind
Comment 12 Kubilay Kocak freebsd_committer freebsd_triage 2019-08-23 12:32:32 UTC
(In reply to Matthias Pfaller from comment #11)

Lovely, thank you Matthias. I'll take care of this
Comment 13 Kubilay Kocak freebsd_committer freebsd_triage 2019-08-23 13:33:53 UTC
During QA, CGI is now found (where is was MISSING prior)

...
Checking for Perl module Template::Plugin::JavaScript...  found
Checking for Perl module CGI...  found
Checking for Perl module HTTP::Date...  found
...


I see the following stage-qa Warning/Notice during QA:

Warning: www/p5-CGI was in Perl CORE.  Check with `corelist CGI 0` and `corelist -a CGI` if it should be conditionally added depending on PERL_LEVEL
Notice: You have some Perl modules as dependencies but you do not have devel/p5-Module-CoreList installed, the perlcore QA check gets better results when using it, especially with older Perl versions.

This was with the following perl in the poudriere build:

[12amd64-dev] `-- Installing perl5-5.30.0...
[12amd64-dev] `-- Extracting perl5-5.30.0: .......... done

Note sure what to do about these notices/warnings. Ask mat@ for input as they're not entirely clear