Created attachment 206818 [details] Patch to add missing dependency When building with sync I noticed, that www/p5-CGI is missing in the dependency list. The attached patch fixes this. Matthias
Thank you for the report and patch Matthias. What were the symptoms of the missing dependency? If it was certain output during port build/packaging, please include the output as an attachment
Comment on attachment 206818 [details] Patch to add missing dependency Approved by: portmgr (blanket: unmaintained port) Pending QA Note: Patch may require PORTREVISION bump
(In reply to Kubilay Kocak from comment #1) I no longer have the log. The synth watchdog would hit because during the installation phase vdradmin-am's install script would ask about installing the CGI module. And without input it would just hang forever.
(In reply to Matthias Pfaller from comment #3) Thanks for the follow-up Matthias So, that sounds like a build or install (stage)stage failure during package creation, rather than a runtime failure after package installation, is that right? Can it currently be reproduced with synth/poudriere with the present port version?
(In reply to Kubilay Kocak from comment #4) I just rerun a build with the original Makefile. The error is generated during the staging phase. -------------------------------------------------------------------------------- -- Phase: stage -------------------------------------------------------------------------------- ===> Staging for vdradmin-am-3.6.10 ===> Generating temporary packing list ===> Creating groups. ===> Creating users /bin/mkdir -p /construction/xports/www/vdradmin-am/work/stage/usr/local/etc/vdradmin-am install -m 0644 /xports/www/vdradmin-am/files/vdradmind.conf /construction/xports/www/vdradmin-am/work/stage/usr/local/etc/vdradmin-am/vdradmind.conf.sample /bin/mkdir -p /construction/xports/www/vdradmin-am/work/stage/var/cache/vdradmin-am /construction/xports/www/vdradmin-am/work/stage/var/log/vdradmin-am /construction/xports/www/vdradmin-am/work/stage/var/run/vdradmin-am ********* Installing VDRAdmin-AM ************* *** Required *** Checking for Perl module locale... found Checking for Perl module Template... found Checking for Perl module Template::Plugin::JavaScript... found Checking for Perl module CGI... MISSING Do you want to install CGI? [y/N]### Watchdog killed runaway process! (no activity for 34 minutes) ### -------------------------------------------------- -- Termination -------------------------------------------------- Finished: Friday, 23 AUG 2019 at 11:36:19 UTC Duration: 00:35:07
Created attachment 206822 [details] http://beefy6.nyi.freebsd.org/data/120amd64-default/508353/logs/vdradmin-am-3.6.10.log (In reply to Matthias Pfaller from comment #5) Nice, thank you. What's interesting is that vdradmin's build on the official package building cluster contains the same MISSING line, but doesn't fail to install (stage)
So it seems like its the interactive prompt "Do you want to install CGI? [y/N]" that's causing the build to ultimately fail (timeout), rather than the missing dependency. Is it clear/apparent what the missing dependency actually changes in the build, either in terms of functional changes, feature support, or files installed?
(In reply to Kubilay Kocak from comment #7) Maybe its different with poudriere (if that's what's used in the building cluster) and the script gets /dev/null as input?
Does starting vdramind without CGI module installed result in the same error as these Debian or Gentoo bugs: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=863043 https://bugs.gentoo.org/show_bug.cgi?id=593506
(In reply to Matthias Pfaller from comment #8) Possibly, we just need confirmation that the package is indeed broken (either, build, packaging or at runtime), and in what manner, in order to verify the change I'm guessing it is (given the Debian / Gentoo bugs), but independent confirmation would be great for this issue
(In reply to Kubilay Kocak from comment #10) bash# pkg delete p5-CGI bash# service vdradmind start Starting vdradmind. Can't locate CGI.pm in @INC (you may need to install the CGI module) (@INC contains: /usr/local/bin/lib/ /usr/local/share/vdradmin-am/lib /usr/local/lib/perl5/site_perl/mach/5.28 /usr/local/lib/perl5/site_perl /usr/local/lib/perl5/5.28/mach /usr/local/lib/perl5/5.28) at /usr/local/bin/vdradmind line 64. BEGIN failed--compilation aborted at /usr/local/bin/vdradmind line 64. /usr/local/etc/rc.d/vdradmind: WARNING: failed to start vdradmind
(In reply to Matthias Pfaller from comment #11) Lovely, thank you Matthias. I'll take care of this
During QA, CGI is now found (where is was MISSING prior) ... Checking for Perl module Template::Plugin::JavaScript... found Checking for Perl module CGI... found Checking for Perl module HTTP::Date... found ... I see the following stage-qa Warning/Notice during QA: Warning: www/p5-CGI was in Perl CORE. Check with `corelist CGI 0` and `corelist -a CGI` if it should be conditionally added depending on PERL_LEVEL Notice: You have some Perl modules as dependencies but you do not have devel/p5-Module-CoreList installed, the perlcore QA check gets better results when using it, especially with older Perl versions. This was with the following perl in the poudriere build: [12amd64-dev] `-- Installing perl5-5.30.0... [12amd64-dev] `-- Extracting perl5-5.30.0: .......... done Note sure what to do about these notices/warnings. Ask mat@ for input as they're not entirely clear
This warnings tells you that CGI used to be part of the Perl distribution. So you do not need to add a dependency to it on Perl versions that still bundle it. Simply run "corelist -a CGI" as the warning tells you to, and see which versions of Perl shipped with it, and then choose whether it needs to always be added as a dependency or it is only required after a certain PERL_LEVEL. Look for PERL_LEVEL's usage in p5-* ports for examples.
Maintainer reset.
Are you still interested in getting this committed?
(In reply to Robert Clausecker from comment #16) I no longer have a vdr installation. I quit watching even recorded live tv :-/
Ok. No problem!