Bug 240269 - Add HISTORY section to getc(3) man page
Summary: Add HISTORY section to getc(3) man page
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Manual Pages (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Sergio Carlavilla Delgado
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-09-02 08:23 UTC by Gordon Bergling
Modified: 2020-08-01 14:08 UTC (History)
4 users (show)

See Also:

Attachments
getc(3) man page patch (886 bytes, patch)
2019-09-02 08:23 UTC, Gordon Bergling 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gordon Bergling freebsd_committer freebsd_triage 2019-09-02 08:23:43 UTC 
Created attachment 207092 [details]
getc(3) man page patch

Add a HISTORY section to getc(3) man page
Comment 1 Warner Losh freebsd_committer freebsd_triage 2020-03-22 14:13:30 UTC 
getc and getw first appear in the V1 man page.
but they aren't in what little v1 sources we have.
They are in the unix-72 which is closer to a v2 or v3 system.
And getc/getw aren't the current modern ones, but took an argument that was an iobuf, not a FILE* They didn't become the modern form until V7 with stdio.
They also changed between v1 and v2 (the buffer size rose from 128 bytes to 512 bytes).
So it's likely better to say 'routines of the same name, but different calling conventions, originated in v1'.
I can't find getchar in the V2 man page, nor v3. But it is in the v4 man pages (man page is named getchr.3, but documents getchar()).
fgetc.c first appears in stdio in V7.
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-04-10 09:38:11 UTC 
A commit references this bug:

Author: carlavilla
Date: Fri Apr 10 09:37:21 UTC 2020
New revision: 359773
URL: https://svnweb.freebsd.org/changeset/base/359773

Log:
  Add HISTORY section to getc(3)

  PR:		240269
  Submitted by:	Gordon Bergling
  Differential Revision:	https://reviews.freebsd.org/D24295

Changes:
  head/lib/libc/stdio/getc.3
Comment 3 Sergio Carlavilla Delgado freebsd_committer freebsd_triage 2020-04-10 09:38:30 UTC 
Thanks for the patch.
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-08-01 14:08:57 UTC 
A commit references this bug:

Author: gbe
Date: Sat Aug  1 14:08:05 UTC 2020
New revision: 363762
URL: https://svnweb.freebsd.org/changeset/base/363762

Log:
  MFC r359773 (by carlavilla): Add HISTORY section to getc(3)

  PR:		240269
  Submitted by:	gbe
  Reviewed by:	imp
  Differential Revision:	https://reviews.freebsd.org/D24295

Changes:
_U  stable/12/
  stable/12/lib/libc/stdio/getc.3