Bug 240310 - www/p5-Gantry: correctly escape $
Summary: www/p5-Gantry: correctly escape $
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-perl mailing list
URL:
Keywords:
Depends on:
Blocks: 229925
  Show dependency treegraph
 
Reported: 2019-09-03 17:26 UTC by Kyle Evans
Modified: 2020-02-21 04:02 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (perl)


Attachments
svn(1) diff against the ports tree (441 bytes, patch)
2019-09-03 17:26 UTC, Kyle Evans
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Evans freebsd_committer 2019-09-03 17:26:40 UTC
Created attachment 207154 [details]
svn(1) diff against the ports tree

In make(1), "$$" is the escaped version of "$", rather than the expected "\$". this expression was getting passed through to ${REINPLACE_CMD} as "s,\NV{..." rathern than the expected "s,$ENV{..." -- bug #229925 makes \N an illegal expression, as ordinary characters will be disallowed from being escaped in preparation for future changes to grant some of these escape sequences GNU-extended behavior.
Comment 1 commit-hook freebsd_committer 2020-02-21 04:01:58 UTC
A commit references this bug:

Author: kevans
Date: Fri Feb 21 04:01:02 UTC 2020
New revision: 526604
URL: https://svnweb.freebsd.org/changeset/ports/526604

Log:
  www/p5-Gantry: correctly escape $

  In make(1), "$$" is the escaped version of "$", rather than the expected
  "\$". this expression was getting passed through to ${REINPLACE_CMD} as
  "s,\NV{..." rathern than the expected "s,$ENV{..." -- bug #229925 makes \N
  an illegal expression, as ordinary characters will be disallowed from being
  escaped in preparation for future changes to grant some of these escape
  sequences GNU-extended behavior.

  PR:		240310
  Approved by:	koobs (mentor), bapt (mentor)
  Approved by:	portmgr (maintainer timeout: 4 months, blanket: bugfix)
  MFH:		2020Q1 (blanket: bugfix)
  Differential Revision:	https://reviews.freebsd.org/D23701

Changes:
  head/www/p5-Gantry/Makefile
Comment 2 commit-hook freebsd_committer 2020-02-21 04:02:59 UTC
A commit references this bug:

Author: kevans
Date: Fri Feb 21 04:01:57 UTC 2020
New revision: 526605
URL: https://svnweb.freebsd.org/changeset/ports/526605

Log:
  MFH: r526604

  www/p5-Gantry: correctly escape $

  In make(1), "$$" is the escaped version of "$", rather than the expected
  "\$". this expression was getting passed through to ${REINPLACE_CMD} as
  "s,\NV{..." rathern than the expected "s,$ENV{..." -- bug #229925 makes \N
  an illegal expression, as ordinary characters will be disallowed from being
  escaped in preparation for future changes to grant some of these escape
  sequences GNU-extended behavior.

  PR:		240310
  Approved by:	koobs (mentor), bapt (mentor)
  Approved by:	portmgr (maintainer timeout: 4 months, blanket: bugfix)
  Differential Revision:	https://reviews.freebsd.org/D23701

  Approved by:	ports-secteam (blanket: bugfix)

Changes:
_U  branches/2020Q1/
  branches/2020Q1/www/p5-Gantry/Makefile