Bug 240359 - ports-mgmt/portlint: Comments in sections (eg: USES/LICENSE) throws FATAL false positives
Summary: ports-mgmt/portlint: Comments in sections (eg: USES/LICENSE) throws FATAL fal...
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Joe Marcus Clarke
URL:
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2019-09-06 07:11 UTC by Kubilay Kocak
Modified: 2019-09-06 07:13 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (marcus)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kubilay Kocak freebsd_committer freebsd_triage 2019-09-06 07:11:51 UTC
The following block:

LICENSE=        MIT
#LICENSE_FILE=  Not yet packaged in sdist

# Actually 2.7, 3.4+
USES=           python
USE_PYTHON=     autoplist distutils


Results in the following portlint output:

===> Validating port with portlint
FATAL: Makefile: extra item "USES" placed in the LICENSE section.
FATAL: Makefile: extra item "USE_PYTHON" placed in the LICENSE section.
2 fatal errors and 0 warnings found.

Expected outcome:

looks fine.

This issue may be more generic in nature, and exhibit itself in other rules relating to block/section identification or order
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2019-09-06 07:13:20 UTC
Forgot to note, in case it helps with analysis or a fix, removing any *one* of the comments results in expected behaviour: looks fine.