Created attachment 207597 [details] Patch Update devel/py-envisage from 4.7.2 to 4.8.0. Add tests. Comment where requirements are defined. QA: portlint : OK port test : OK poudriere : OK (py36, 12Ramd64) make test : OK (also in 'poudriere -i')
Tips: When a port supports multiple Python versions, it's good to test against a non-default Python version as well (many issues are picked up this way) Provide a changelog URL entry in the URL field for version updates, as it can help committers determine when security/bugfix releases can / need to / should be merged
Note form the changelog: - Remove dependency on the ``nose`` package, and rename test modules. All tests can now be discovered and run using ``unittest``. (#200, #194) The nose dependency can be dropped
(In reply to Kubilay Kocak from comment #2) Upstream uses their own test manager, which is not ported. Without the manager, two tests fail. With nose, all tests pass. I plan to clarify with upstream what might be the reason of the failures. I think, nose can be kept meanwhile.
(In reply to vladimir.chukharev from comment #3) Thank you for clarifying. Have you tried "-m unittest discover" ?
(In reply to Kubilay Kocak from comment #4) Yes, that's how it mainly works. With no 'discover', it does not find any test.
Created attachment 207636 [details] New patch I clarified with upstream about tests and accordingly corrected the patch. No TEST_DEPENDS needed, test invocation is different.
A commit references this bug: Author: rodrigo Date: Sun Sep 22 09:16:16 UTC 2019 New revision: 512566 URL: https://svnweb.freebsd.org/changeset/ports/512566 Log: Update devel/py-envisage from 4.7.2 to 4.8.0. Add tests Comment where requirements are defined. PR: 240661 Submitted by: <vladimir.chukharev@gmail.com> (maintainer) Changes: head/devel/py-envisage/Makefile head/devel/py-envisage/distinfo
committed, thanks.