Bug 240986 - [exp-run] Mk/Uses/go.mk: Omit symbol table and debug information by default
Summary: [exp-run] Mk/Uses/go.mk: Omit symbol table and debug information by default
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL: https://reviews.freebsd.org/D21730
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-01 21:32 UTC by Dmitri Goutnik
Modified: 2019-11-16 12:55 UTC (History)
1 user (show)

See Also:
dmgk: exp-run?


Attachments
D21730_D21854.diff v0 (58.10 KB, patch)
2019-10-01 21:32 UTC, Dmitri Goutnik
no flags Details | Diff
D21730_D21854.diff v1 (58.10 KB, patch)
2019-10-06 14:18 UTC, Dmitri Goutnik
no flags Details | Diff
D21730_D21854.diff v2 (58.08 KB, patch)
2019-10-09 16:16 UTC, Dmitri Goutnik
no flags Details | Diff
D21730_D21854.diff v3 (58.01 KB, patch)
2019-10-21 21:29 UTC, Dmitri Goutnik
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer 2019-10-01 21:32:37 UTC
Created attachment 207998 [details]
D21730_D21854.diff v0

Mk/Uses/go.mk: Add linker flags to omit symbol table and debug information
unless WITH_DEBUG is defined or port sets its own -ldflags.

Bump PORTREVISION of dependent ports to force relinking.

Attached is a combined patch of review D21730 and review D21854
Comment 1 Dmitri Goutnik freebsd_committer 2019-10-06 14:18:05 UTC
Created attachment 208138 [details]
D21730_D21854.diff v1

Rebase after ports r513850 and ports r513852
Comment 2 Dmitri Goutnik freebsd_committer 2019-10-09 16:16:03 UTC
Created attachment 208206 [details]
D21730_D21854.diff v2

Rebase after ports r514146
Comment 3 Dmitri Goutnik freebsd_committer 2019-10-21 21:29:35 UTC
Created attachment 208493 [details]
D21730_D21854.diff v3

Rebase on ports r515123
Comment 5 Dmitri Goutnik freebsd_committer 2019-11-04 12:05:01 UTC
(In reply to Antoine Brodin from comment #4)
Hi Antoine,

This is a known issue with go on freebsd/386: https://github.com/golang/go/issues/28054, unrelated to this PR.
Comment 6 Dmitri Goutnik freebsd_committer 2019-11-16 12:55:29 UTC
Committed as ports r517743, ports r517745