Bug 241053 - databases/postgresql12-server: LLVM option assumes OPENSSL is enabled
Summary: databases/postgresql12-server: LLVM option assumes OPENSSL is enabled
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Palle Girgensohn
URL:
Keywords:
Depends on:
Blocks: 241166
  Show dependency tree / graph
 
Reported: 2019-10-04 11:41 UTC by noah.bergbauer
Modified: 2019-10-17 14:13 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (pgsql)

Attachments
Patch to fix packaging errors (1.76 KB, patch)
2019-10-09 18:21 UTC, Artyom Davidov 		no flags Details | Diff
Archive with the build logs (229.06 KB, application/x-compressed)
2019-10-09 18:29 UTC, Artyom Davidov 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description noah.bergbauer 2019-10-04 11:41:30 UTC 
The current pkg-plist-server includes a long list of LLVM bitcode (.bc) files that are packaged if the LLVM build option is enabled. However some of these files are not compiled if certain other options are disabled. For example with OPENSSL and GSSAPI disabled I see this error:

===========================================================================
=======================<phase: package        >============================
===>  Building package for postgresql12-server-12.0
pkg-static: Unable to access file /wrkdirs/usr/ports/databases/postgresql12-server/work/stage/usr/local/lib/postgresql/bitcode/postgres/libpq/be-gssapi-common.bc:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/databases/postgresql12-server/work/stage/usr/local/lib/postgresql/bitcode/postgres/libpq/be-secure-gssapi.bc:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/databases/postgresql12-server/work/stage/usr/local/lib/postgresql/bitcode/postgres/libpq/be-secure-openssl.bc:No such file or directory
*** Error code 1

This affects databases/postgresql11-server as well.
Comment 1 Artyom Davidov 2019-10-09 18:21:59 UTC 
Created attachment 208208 [details]
Patch to fix packaging errors

Hello,

This patch will fix this packaging issue for the postgresql12-server port.

It will do so by declaring two additional PLIST variables %%GSSAPI%% and %%SSL%% in the Makefile for the corresponding options, that should be used in pkg-plist-server to isolate missing files at the package stage.
Comment 2 Artyom Davidov 2019-10-09 18:29:43 UTC 
Created attachment 208209 [details]
Archive with the build logs

This is the Synth test build logs performed on FreeBSD 11.3 adm64 machine.

This archive includes four build logs with LLVM ON, and different GSSAPI and SSL options.
Comment 3 Artyom Davidov 2019-10-09 20:03:01 UTC 
Added patch for the databases/postgresql11-server port

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241166
Comment 4 Artyom Davidov 2019-10-16 18:41:55 UTC 
Ping!

Can anyone please take a look at this, 'cause currently it is not possible to build databases/postgresql12-server with LLVM and without GSSAPI or\and SSL
Comment 5 Palle Girgensohn freebsd_committer freebsd_triage 2019-10-17 14:13:04 UTC 
Committed. Thanks!
Comment 6 commit-hook freebsd_committer freebsd_triage 2019-10-17 14:13:14 UTC 
A commit references this bug:

Author: girgen
Date: Thu Oct 17 14:12:50 UTC 2019
New revision: 514661
URL: https://svnweb.freebsd.org/changeset/ports/514661

Log:
  Fix PLIST problems when building with LLVM but without GSSAPI or OPENSSL.

  PR:		241053, 241166
  Submitted by:	Artyom Davidov

Changes:
  head/databases/postgresql12-server/Makefile
  head/databases/postgresql12-server/pkg-plist-server