Bug 241105 - devel/meson: Update to 0.52.0
Summary: devel/meson: Update to 0.52.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL: https://mesonbuild.com/Release-notes-...
Keywords: patch
Depends on: 240182
Blocks: 242297
  Show dependency treegraph
Reported: 2019-10-06 20:53 UTC by Jan Beich
Modified: 2019-11-29 15:37 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)
antoine: exp-run+

v1 (4.09 KB, patch)
2019-10-06 20:53 UTC, Jan Beich
no flags Details | Diff
v1.1 (8.65 KB, patch)
2019-10-07 22:24 UTC, Jan Beich
no flags Details | Diff
v1.2 (9.65 KB, patch)
2019-10-08 00:01 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2019-10-06 20:53:49 UTC
Created attachment 208145 [details]
Comment 1 Ting-Wei Lan 2019-10-07 17:40:49 UTC
I uploaded new patches to GitHub pull requests to fix tests today. You may want to use the updated patches in ports. There is no functionality change.

Comment 2 Jan Beich freebsd_committer 2019-10-07 22:24:10 UTC
Created attachment 208160 [details]

- Update files/patch-mesonbuild_dependencies_base.py
- Connect tests to "make test"

I didn't add all dependencies for "make test":
- Some tests rely on "python" and "python3" binaries (maybe a bug)
- Many tests check dependency detection e.g., gnome, qt, llvm, boost
Comment 3 Jan Beich freebsd_committer 2019-10-08 00:01:20 UTC
Created attachment 208161 [details]

- Limit "make test" to unit tests to shave time and false positives
- Make all tests pass on 13.0 (and maybe 12.1), so regressions are easier to notice
Comment 4 Ting-Wei Lan 2019-10-08 13:53:08 UTC
(In reply to Jan Beich from comment #3)
It is surprising to know that you are able to run unit tests on FreeBSD! I never expect it to work and I remember that I saw a few failures before. It is nice to see the test command being added to ports.
Comment 5 Antoine Brodin freebsd_committer 2019-10-09 17:54:46 UTC
Exp-run looks fine
Comment 6 commit-hook freebsd_committer 2019-10-09 19:18:05 UTC
A commit references this bug:

Author: jbeich
Date: Wed Oct  9 19:17:21 UTC 2019
New revision: 514187
URL: https://svnweb.freebsd.org/changeset/ports/514187

  devel/meson: update to 0.52.0

  - Update patches [1]
  - Connect tests to the framework

  Changes:	https://mesonbuild.com/Release-notes-for-0-52-0.html
  Changes:	https://github.com/mesonbuild/meson/compare/0.51.2...0.52.0
  PR:		241105
  Submitted by:	Ting-Wei Lan [1]
  Exp-run by:	antoine

Comment 7 Ting-Wei Lan 2019-10-12 17:56:57 UTC
I found two issues when using meson 0.52.0.

1. dconf and gnome-builder can't be built from git master.

The issue was discussed in https://github.com/mesonbuild/meson/pull/5936 and I filed https://gitlab.gnome.org/GNOME/dconf/issues/59 and https://gitlab.gnome.org/GNOME/gnome-builder/issues/1057.

2. -Wl,-rpath-link may appear in the wrong order.

I reported it at https://github.com/mesonbuild/meson/issues/6027, and https://github.com/mesonbuild/meson/pull/6031 attempts to fix it.