Bug 241112 - devel/py-path.py: Update to 11.5.2, Take MAINTAINER'ship
Summary: devel/py-path.py: Update to 11.5.2, Take MAINTAINER'ship
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-07 10:07 UTC by Jan Beich
Modified: 2019-10-22 00:52 UTC (History)
0 users

See Also:
wg: maintainer-feedback+


Attachments
v1 (6.55 KB, patch)
2019-10-07 10:07 UTC, Jan Beich
no flags Details | Diff
v1.1 (6.68 KB, patch)
2019-10-07 10:15 UTC, Jan Beich
no flags Details | Diff
v1.2 (6.69 KB, patch)
2019-10-07 10:24 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2019-10-07 10:07:19 UTC
Created attachment 208148 [details]
v1

Limited to the last version that supports Python 2. I haven't tested www/py-flexget with Python 3 yet.

$ make test
===>  Testing for py36-path.py-11.5.2
===>   py36-path.py-11.5.2 depends on package: py36-pytest-flake8>0 - found
===>   py36-path.py-11.5.2 depends on package: py36-packaging>0 - found
===>   py36-path.py-11.5.2 depends on file: /usr/local/bin/python3.6 - found
============================================== test session starts ===============================================
platform freebsd12 -- Python 3.6.9, pytest-4.5.0, py-1.8.0, pluggy-0.12.0
rootdir: /wrkdirs/usr/ports/devel/py-path.py/work-py36/path.py-11.5.2, inifile: pytest.ini
plugins: flake8-1.0.4, shutil-1.7.0
collected 79 items

path.py s.....                                                                                             [  7%]
setup.py s                                                                                                 [  8%]
test_path.py s.............................................E...........sssssss......                       [ 98%]
docs/conf.py s                                                                                             [100%]

===================================================== ERRORS =====================================================
______________________ ERROR at setup of TestUnicode.test_walkdirs_with_unicode_name[Path] _______________________

self = <test_path.TestUnicode object at 0x29bfa82c>
tmpdir = local('/tmp/pytest-of-root/pytest-5/test_walkdirs_with_unicode_nam0')

    @pytest.fixture(autouse=True)
    def unicode_name_in_tmpdir(self, tmpdir):
        # build a snowman (dir) in the temporary directory
\x1b[1m>       Path(tmpdir).joinpath('\u2603').mkdir()\x1b[0m

test_path.py:974:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = Path('/tmp/pytest-of-root/pytest-5/test_walkdirs_with_unicode_nam0/\u2603'), mode = 511

    def mkdir(self, mode=0o777):
        """ .. seealso:: :func:`os.mkdir` """
>       os.mkdir(self, mode)
E       UnicodeEncodeError: 'ascii' codec can't encode character '\u2603' in position 61: ordinal not in range(128)

path.py:1199: UnicodeEncodeError
================================= 67 passed, 11 skipped, 1 error in 4.40 seconds =================================
*** Error code 1

Stop.
Comment 1 Jan Beich freebsd_committer freebsd_triage 2019-10-07 10:15:00 UTC
Created attachment 208149 [details]
v1.1

- Define LICENSE_FILE
- Sort TEST_DEPENDS by port origin
- Adjust commit message
Comment 2 Jan Beich freebsd_committer freebsd_triage 2019-10-07 10:24:35 UTC
Created attachment 208150 [details]
v1.2

Define NO_ARCH per pkg(8) suggestion:

$ poudriere testport -j 120amd64 devel/py-path.py@py27
[...]
=======================<phase: package        >============================
===>  Building package for py27-path.py-11.5.2
pkg-static: DEVELOPER_MODE: Notice: arch "FreeBSD:12:i386" -- no architecture specific files found:
**** could this package use a wildcard architecture?
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-10-07 13:15:24 UTC
A commit references this bug:

Author: jbeich
Date: Mon Oct  7 13:14:53 UTC 2019
New revision: 513945
URL: https://svnweb.freebsd.org/changeset/ports/513945

Log:
  devel/py-path.py: update to 11.5.2

  - Connect tests to the framework
  - Define LICENSE_FILE as MIT has many styles
  - Skip later versions due to lack of Python 2 support
  - Take maintainership

  Changes:	https://github.com/jaraco/path.py/compare/8.1.2...11.5.2
  PR:		241112
  Approved by:	wg (maintainer)
  MFH:		2019Q4 (www/py-flexget stability fix)

Changes:
  head/devel/py-path.py/Makefile
  head/devel/py-path.py/distinfo
  head/www/py-flexget/Makefile
  head/www/py-flexget/files/patch-02-path.py-8.1
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-10-22 00:52:59 UTC
A commit references this bug:

Author: jbeich
Date: Tue Oct 22 00:52:52 UTC 2019
New revision: 515164
URL: https://svnweb.freebsd.org/changeset/ports/515164

Log:
  MFH: r513945

  devel/py-path.py: update to 11.5.2

  - Connect tests to the framework
  - Define LICENSE_FILE as MIT has many styles
  - Skip later versions due to lack of Python 2 support
  - Take maintainership

  Changes:	https://github.com/jaraco/path.py/compare/8.1.2...11.5.2
  PR:		241112
  Approved by:	wg (maintainer)
  Approved by:	ports-secteam (miwi)

Changes:
_U  branches/2019Q4/
  branches/2019Q4/devel/py-path.py/Makefile
  branches/2019Q4/devel/py-path.py/distinfo
  branches/2019Q4/www/py-flexget/Makefile
  branches/2019Q4/www/py-flexget/files/patch-02-path.py-8.1