Bug 241627 - [exp-run] use internal variables in xorg.mk to silence spurious messages about needing USES=xorg
Summary: [exp-run] use internal variables in xorg.mk to silence spurious messages abou...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Package Infrastructure (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL: https://reviews.freebsd.org/D22210
Keywords:
Depends on:
Blocks: 238988
  Show dependency treegraph
 
Reported: 2019-10-31 20:51 UTC by Niclas Zeising
Modified: 2019-11-06 20:08 UTC (History)
1 user (show)

See Also:
zeising: exp-run?


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Niclas Zeising freebsd_committer 2019-10-31 20:51:20 UTC
Hi!
See https://reviews.freebsd.org/D22210 for details.
The patch attempts to silence spurious warnings about needing USES=xorg in certain conditions.  Patch for exp-run is in the review.

Thanks!
Comment 1 commit-hook freebsd_committer 2019-11-06 19:03:00 UTC
A commit references this bug:

Author: zeising
Date: Wed Nov  6 19:02:43 UTC 2019
New revision: 516921
URL: https://svnweb.freebsd.org/changeset/ports/516921

Log:
  Mk/Uses: Add USES+=xorg when including xorg.mk

  Add USES+=xorg to the places where MK/Uses/xorg.mk is included from other
  files in the Uses infrastructure.  This is done to silence an erroneous
  warning about USES=xorg not being set when using USES=gl, motif or xorg-cat,
  even when it's included from the framework.

  This is a different proposal than what was originally suggested in pr 241627
  and https://reviews.freebsd.org/D22210 .

  PR:		238988, 241627
  Discussed with:	mat
  MFH:		2019Q4
  Differential Revision:	https://reviews.freebsd.org/D22210

Changes:
  head/Mk/Uses/gl.mk
  head/Mk/Uses/motif.mk
  head/Mk/Uses/xorg-cat.mk
Comment 2 Niclas Zeising freebsd_committer 2019-11-06 20:08:48 UTC
Closing this, since a different solution has been committed.