Bug 241637 - Mk/Uses/go.mk directory conflict
Summary: Mk/Uses/go.mk directory conflict
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitri Goutnik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-01 07:12 UTC by Christopher Hall
Modified: 2019-11-02 12:36 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Hall 2019-11-01 07:12:34 UTC
I just happen to have two go dependencies using the same link, could only separate by setting different versions to get:

lrwxr-xr-x    1 hsw      hsw           50 Nov  1 15:00 go-1.1.7/
lrwxr-xr-x    1 hsw      hsw           57 Nov  1 15:00 go-1.1.8/

the tuple that caused this is:

json-iterator:go:v1.1.8:json_iterator_go/vendor/github.com/json-iterator/go \
ugorji:go:v1.1.7:ugorji_go/vendor/github.com/ugorji/go \

I think migh need to add a the account as part of the link name.
Comment 1 Dmitri Goutnik freebsd_committer 2019-11-01 12:20:18 UTC
(In reply to Christopher Hall from comment #0)
This is not so much go.mk issue but the issue with how Github packs release tarballs. If json-iterator/go and ugorji/go have the same tag (e.g. v1.1.7), their tarballs will both have go-1.1.7 subdirectory which will then conflict (install sources to the same place) on extract.

The usual workaround in these cases is to replace on of the tags with corresponding commit ID, e.g.

json-iterator:go:v1.1.8:json_iterator_go/vendor/github.com/json-iterator/go \
ugorji:go:23ab95ef5dc3:ugorji_go/vendor/github.com/ugorji/go \

this way json-iterator/go will be extracted to go-1.1.8 and ugorji/go to go-23ab95ef5dc3

modules2tuple probably can be taught to look for these conflicts and do the replacement automatically.
Comment 2 commit-hook freebsd_committer 2019-11-02 12:36:04 UTC
A commit references this bug:

Author: dmgk
Date: Sat Nov  2 12:35:02 UTC 2019
New revision: 516315
URL: https://svnweb.freebsd.org/changeset/ports/516315

Log:
  ports-mgmt/modules2tuple: Update to 1.10.0

  Changes:	https://github.com/dmgk/modules2tuple/releases/tag/v1.10.0

  PR:		241637
  Approved by:	tz (mentor, implicit)

Changes:
  head/ports-mgmt/modules2tuple/Makefile
  head/ports-mgmt/modules2tuple/distinfo