Bug 242103 - net/asterisk16 - net/asterisk13: opus codec not built
Summary: net/asterisk16 - net/asterisk13: opus codec not built
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-20 10:33 UTC by ben
Modified: 2019-11-22 09:18 UTC (History)
0 users

See Also:
madpilot: maintainer-feedback+
madpilot: merge-quarterly+


Attachments
attempted fix (751 bytes, patch)
2019-11-20 10:33 UTC, ben
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ben 2019-11-20 10:33:12 UTC
Created attachment 209274 [details]
attempted fix

Maybe I'm missing something, but it seems like the third-party Opus codec doesn't get installed even if selected.  The attached patch fixes it for me.

Thanks!
Comment 1 Guido Falsi freebsd_committer 2019-11-20 11:32:46 UTC
Thanks for reporting and the patch.

I need to test things a little before committing this.

I'm not using OPUS myself so this could have slipped by. And it is also possible the port has changed it's build system so that your patch has become necessary.

This will also need merging to 2019Q4 once accepted in the tree.
Comment 2 Guido Falsi freebsd_committer 2019-11-20 11:33:29 UTC
Most probably asterisk13 is also affected.
Comment 3 commit-hook freebsd_committer 2019-11-20 21:52:03 UTC
A commit references this bug:

Author: madpilot
Date: Wed Nov 20 21:51:11 UTC 2019
New revision: 518056
URL: https://svnweb.freebsd.org/changeset/ports/518056

Log:
  Really build the opus module when the OPUS option is enabled.

  PR:		242103
  Submitted by:	ben@desync.com
  MFH:		2019Q4

Changes:
  head/net/asterisk13/Makefile
  head/net/asterisk16/Makefile
Comment 4 commit-hook freebsd_committer 2019-11-22 09:14:36 UTC
A commit references this bug:

Author: madpilot
Date: Fri Nov 22 09:13:36 UTC 2019
New revision: 518131
URL: https://svnweb.freebsd.org/changeset/ports/518131

Log:
  MFH: r518056

  Really build the opus module when the OPUS option is enabled.

  PR:		242103
  Submitted by:	ben@desync.com

  Approved by:	ports-secteam (joneum)

Changes:
_U  branches/2019Q4/
  branches/2019Q4/net/asterisk13/Makefile
  branches/2019Q4/net/asterisk16/Makefile
Comment 5 Guido Falsi freebsd_committer 2019-11-22 09:18:16 UTC
Patch committed and merged to quarterly.

Thanks!