Created attachment 209322 [details] shar archive of initial port version Apple AirScan compatible SANE web frontend
Created attachment 209325 [details] shar archive of initial port version A port's date-version is supposed to be date of last commit, so fixed that. Also an additional patch to fix obtaining hostname on BSD.
Created attachment 209711 [details] shar archive of initial port version I simplified the etc/rc.d script for this. Also removed pkg-plist and used PLIST_FILES= in Makefile instead since there is only one file that's installed. Also renamed the port from "graphics/airsane" to "graphics/airsaned" because that is what's installed and that allows further Makefile cleanups.
Hi, Could you bump this to latest release if its still of interest otherwise please close this bug report. I apologize for very long handling time. Best regards, Daniel
Created attachment 228458 [details] shar of airsaned-d20211018 As requested.
Great, thanks! Can you also try to get the patches submitted upstream?
Created attachment 228459 [details] Patch for airsaned Remove # $FreeBSD:$ (obsolete) Change PORTVERSION to DISTVERSION and other related variables to follow Porter's Handbook https://docs.freebsd.org/en/books/porters-handbook/book/ - "Example 19. Using USE_GITHUB to Access a Commit Between Two Versions" Add jpeg dependency to USES= Change hardcoded GCC c++11 library to generic c++11 library dependency to avoid pulling in GCC unnecessarily Move includes via CFLAGS to USES= localbase:ldflags
Hi, Can you give this patch a try and I don't see why we need to hardcode GCC dependency? Best regards, Daniel
Looks good. The gcc must have been needed back when I did the original version in October 2019, but it does work now without. And thanks for finding the version number!
Created attachment 228462 [details] update to 0.3.2.51 I've updated the patches so that they are suitable for sending to upstream. At the same time, I see upstream commited this morning, so I rebased to that.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=b75c465cc063856bd854ff9e91c4a09d2dea3de4 commit b75c465cc063856bd854ff9e91c4a09d2dea3de4 Author: J.R. Oldroyd <fbsd@opal.com> AuthorDate: 2021-10-08 06:14:55 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2021-10-08 07:06:34 +0000 graphics/airsaned: New port: Apple AirScan compatible SANE web frontend A SANE WebScan frontend that supports Apple's AirScan protocol. Scanners are detected automatically, and published through mDNS. Acquired images may be transferred in JPEG, PNG, and PDF/raster format. WWW: https://github.com/SimulPiscator/AirSane PR: 242144 Approved by: arrowd (mentor) Differential Revision: https://reviews.freebsd.org/D32314 graphics/Makefile | 1 + graphics/airsaned/Makefile (new) | 32 ++++++++++ graphics/airsaned/distinfo (new) | 3 + graphics/airsaned/files/airsaned.in (new) | 24 ++++++++ graphics/airsaned/files/patch-CMakeLists.txt (new) | 71 ++++++++++++++++++++++ .../files/patch-imageformats-pngencoder.cpp (new) | 20 ++++++ .../airsaned/files/patch-server-server.cpp (new) | 16 +++++ .../airsaned/files/patch-web-httpserver.cpp (new) | 12 ++++ .../files/patch-zeroconf-hotplugnotifier.cpp (new) | 14 +++++ graphics/airsaned/pkg-descr (new) | 21 +++++++ graphics/airsaned/pkg-plist (new) | 4 ++ 11 files changed, 218 insertions(+)
Your version bump actually flew by my radar (except for upstreamable patch changes) and we don't need to bump the port for a change in the readme file. Unless there's a major fix etc I'd suggest that we stick to releases for now on. Committed with some modifications, thanks for your contribution and patience!