Bug 242329 - GitLab doesn't seem to require GL_COMMIT any more
Summary: GitLab doesn't seem to require GL_COMMIT any more
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-30 23:08 UTC by Yuri Victorovich
Modified: 2019-12-01 15:34 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer 2019-11-30 23:08:01 UTC
The framework prints: GL_COMMIT is a required 40 character hash for use USE_GITLAB

But the tarball URL doesn't contain commit any more.
Now 
> MASTER_SITES=https://gitlab.com/${PORTNAME}/${PORTNAME}/-/archive/${DISTVERSIONFULL}/
is sufficient.

Testcase: port audio/zrythm
Comment 1 Jan Beich freebsd_committer 2019-12-01 10:32:16 UTC
Looks like ${GL_COMMIT} is stripped if archive name matches ${GH_PROJECT}-${GH_TAGNAME} e.g.,

$ fetch https://code.videolan.org/videolan/dav1d/-/archive/0.5.1/dav1d-0.5.1.tar.gz
$ tar tvf dav1d-0.5.1.tar.gz
drwxrwxr-x  0 root   root        0 Oct 25 19:38 dav1d-0.5.1/

$ fetch https://code.videolan.org/videolan/dav1d/-/archive/0.5.1/0.5.1.tar.gz
$ tar tvf 0.5.1.tar.gz | head -1
drwxrwxr-x  0 root   root        0 Oct 25 19:38 dav1d-0.5.1-bb160f09fa7ad132f4b6a014ac8e168b913ee3ab/

$ fetch https://code.videolan.org/videolan/dav1d/-/archive/bb160f0/dav1d-bb160f0.tar.gz
$ tar tvf dav1d-bb160f0.tar.gz | head -1
drwxrwxr-x  0 root   root        0 Oct 25 19:38 dav1d-bb160f0/

$ fetch https://code.videolan.org/videolan/dav1d/-/archive/0.5.1/foo.tar.gz
$ tar tvf foo.tar.gz
drwxrwxr-x  0 root   root        0 Oct 25 19:38 dav1d-0.5.1-bb160f09fa7ad132f4b6a014ac8e168b913ee3ab/

$ fetch https://code.videolan.org/videolan/dav1d/-/archive/bb160f0/bar.tar.gz
$ tar tvf bar.tar.gz
drwxrwxr-x  0 root   root        0 Oct 25 19:38 dav1d-bb160f0-bb160f09fa7ad132f4b6a014ac8e168b913ee3ab/

$ fetch -o qux.tar.gz https://code.videolan.org/videolan/dav1d/-/archive/bb160f0/dav1d-0.5.1.tar.gz
$ tar tvf qux.tar.gz
drwxrwxr-x  0 root   root        0 Oct 25 19:38 dav1d-bb160f0-bb160f09fa7ad132f4b6a014ac8e168b913ee3ab/
Comment 2 Yuri Victorovich freebsd_committer 2019-12-01 15:34:46 UTC
https://gitlab.com doesn't accept URLs with hashes as the FreeBSD framework constructs them, and ports become unfetchable. But other GitLab installations work as before and do accept hashes.