Bug 242613 - devel/cdialog: cdialog-1.3-20180621 displays ugly black bars
Summary: devel/cdialog: cdialog-1.3-20180621 displays ugly black bars
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-12 21:36 UTC by Serge Volkov
Modified: 2019-12-22 21:02 UTC (History)
3 users (show)

See Also:
jcpierri: maintainer-feedback+


Attachments
cdialog-1.3.20191210,2.patch (1.43 KB, patch)
2019-12-13 06:05 UTC, takefu
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Serge Volkov 2019-12-12 21:36:47 UTC
Prior to 1.3-20180621 cdialog would fill unused space at the end of the
line with the background color.  However, starting with 1.3-20180621
it doesn't. Instead, it seems to fill with whatever the terminal's
background color was prior to starting dialog.

Steps to reproduce on FreeBSD current:
cat /etc/rc.conf | cdialog --programbox 23 76

With older versions of dialog the box's background is a consistent
color.  With 1.3-20180621, the trailing unused part of each
line is filled with (on my terminal at least) black.

Details here https://lists.gnu.org/archive/html/bug-ncurses/2019-02/msg00010.html

The problem is evident in FreeBSD's ports tree's version.

The latest upstream version of dialog 1.3.20191210 fixes this problem for me.

Can someone update the version of devel/cdialog port?
Comment 1 takefu 2019-12-13 06:05:41 UTC
Created attachment 209907 [details]
cdialog-1.3.20191210,2.patch

Update to 1.3.20191210

fix
  STRIP_CMD
  patch-EXAMPLES
Comment 2 Serge Volkov 2019-12-18 14:31:03 UTC
With such changes when building and installing the port, I get the following:

Registering installation for cdialog-1.3.20191210,2
(cdialog-1.3.20191210,2) /usr/ports/devel/cdialog/work/stage//usr/local/bin/cdialog - required shared library libncursesw.so.8 not found
(cdialog-1.3.20191210,2) /usr/ports/devel/cdialog/work/stage//usr/local/bin/cdialog - required shared library libc.so.7 not found
Installing cdialog-1.3.20191210,2...

However, after this, a new cdialog works.
Comment 3 Serge Volkov 2019-12-19 09:09:31 UTC
Sorry. I tried again to patch, make and install. And everything turned out without errors.
Comment 4 Josmar 2019-12-22 21:02:13 UTC
Tested the patch and it works correctly on 12.1-RELEASE-p1 and 11.3-RELEASE-p5.
The issue reported no longer happens on either.
Good job!