Bug 242682 - [patch] devel/git: helpful description for CURL option
Summary: [patch] devel/git: helpful description for CURL option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Renato Botelho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-17 11:40 UTC by Piotr Smyrak
Modified: 2019-12-30 14:54 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (garga)


Attachments
patch to devel/git Makefile (323 bytes, patch)
2019-12-17 11:40 UTC, Piotr Smyrak
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Smyrak 2019-12-17 11:40:54 UTC
Created attachment 210003 [details]
patch to devel/git Makefile

Turning off CURL OPTIONS knob has somewhat unexpected consequences, ie. disables HTTPS transport, thus no Github access. 

This is not evident from the default option description. The tiny patch adds non standard knob description specifically mentioning HTTPS unavailability, when it gets turned off.
Comment 1 commit-hook freebsd_committer 2019-12-30 14:54:23 UTC
A commit references this bug:

Author: garga
Date: Mon Dec 30 14:53:47 UTC 2019
New revision: 521494
URL: https://svnweb.freebsd.org/changeset/ports/521494

Log:
  devel/git: helpful description for CURL option

  Turning off CURL OPTIONS knob has somewhat unexpected consequences, ie.
  disables HTTPS transport, thus no Github access.

  This is not evident from the default option description. The tiny patch
  adds non standard knob description specifically mentioning HTTPS
  unavailability, when it gets turned off.

  While here, sort *_DESC variables alphabetically.

  PR:		242682
  Submitted by:	Piotr Smyrak <ps.ports@smyrak.com>
  Sponsored by:	Rubicon Communications, LLC (Netgate)

Changes:
  head/devel/git/Makefile