Bug 243268 - x11-themes/greybird-theme: Update to 3.22.11
Summary: x11-themes/greybird-theme: Update to 3.22.11
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2020-01-11 14:35 UTC by Olivier Duchateau
Modified: 2020-01-12 17:08 UTC (History)
2 users (show)

See Also:
madpilot: maintainer-feedback+


Attachments
Patch to update x11-themes/greybird-theme (41.48 KB, patch)
2020-01-11 14:35 UTC, Olivier Duchateau
no flags Details | Diff
Modified patch (41.52 KB, patch)
2020-01-12 14:30 UTC, Guido Falsi
no flags Details | Diff
patch that compiles (41.53 KB, patch)
2020-01-12 14:37 UTC, Guido Falsi
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Duchateau 2020-01-11 14:35:59 UTC
Created attachment 210621 [details]
Patch to update x11-themes/greybird-theme

- Update to 3.22.11
- Adjust dependencies (it uses the meson build system)
Comment 1 Guido Falsi freebsd_committer 2020-01-11 15:31:25 UTC
Thanks for the patch.

I'll be testing it and commit once ready.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2020-01-11 15:41:20 UTC
^Triage: Assign to committer resolving
Comment 3 Guido Falsi freebsd_committer 2020-01-12 14:30:54 UTC
Created attachment 210658 [details]
Modified patch

I'm testing the patch in poudriere.

With your patch I was getting failures, so I modified it. It looks like the theme now requires glib-compile-resources from glib20, and also uses pkgconfig. I added those to the port dependencies. My patch includes these changes.

But it still gives me errors about not recognizing svg files, so I added gdkpixbuf2 since glib-compile-resources states it uses gdk-pixbuf-pixdata to read pixel data files. Unluckily this did not help and I'm at a loss on how to fix this. Most probably still some missing dependency. Do you have an idea what could be needed?

Here is the log of the error I'm getting:

=======================<phase: stage          >============================
===>  Staging for greybird-theme-3.22.11
===>   greybird-theme-3.22.11 depends on package: gtk-murrine-engine>=0.98.1 - found
===>   Generating temporary packing list
[1/7] glib-compile-resources ../light/gtk-3.0/gtk.gresource.xml --sourcedir /wrkdirs/usr/ports/x11-themes/greybird-theme/work/Greybird-3.22.11/light/gtk-3.0 --sourcedir ../light --internal --generate --target light/gtk.gresource --dependency-file light/gtk.gresource.d
FAILED: light/gtk.gresource 
glib-compile-resources ../light/gtk-3.0/gtk.gresource.xml --sourcedir /wrkdirs/usr/ports/x11-themes/greybird-theme/work/Greybird-3.22.11/light/gtk-3.0 --sourcedir ../light --internal --generate --target light/gtk.gresource --dependency-file light/gtk.gresource.d
failed to load "/wrkdirs/usr/ports/x11-themes/greybird-theme/work/Greybird-3.22.11/light/gtk-3.0/assets/bullet-symbolic.svg": Couldn?t recognize the image file format for file ?/wrkdirs/usr/ports/x11-themes/greybird-theme/work/Greybird-3.22.11/light/gtk-3.0/assets/bullet-symbolic.svg?
../light/gtk-3.0/gtk.gresource.xml: Child process exited with code 1.
[2/7] /usr/local/bin/glib-compile-resources ../dark/gtk-3.0/gtk.gresource.xml --target dark/gtk.gresource --sourcedir /wrkdirs/usr/ports/x11-themes/greybird-theme/work/Greybird-3.22.11/dark/gtk-3.0
FAILED: dark/gtk.gresource 
/usr/local/bin/glib-compile-resources ../dark/gtk-3.0/gtk.gresource.xml --target dark/gtk.gresource --sourcedir /wrkdirs/usr/ports/x11-themes/greybird-theme/work/Greybird-3.22.11/dark/gtk-3.0
failed to load "/wrkdirs/usr/ports/x11-themes/greybird-theme/work/Greybird-3.22.11/dark/gtk-3.0/assets/bullet-symbolic.svg": Couldn?t recognize the image file format for file ?/wrkdirs/usr/ports/x11-themes/greybird-theme/work/Greybird-3.22.11/dark/gtk-3.0/assets/bullet-symbolic.svg?
../dark/gtk-3.0/gtk.gresource.xml: Child process exited with code 1.
[3/7] /usr/local/bin/sassc -a -M -t compact ../light/gtk-3.0/gtk-contained-dark.scss light/gtk-dark.css
[4/7] /usr/local/bin/sassc -a -M -t compact ../dark/gtk-3.0/gtk-contained.scss dark/gtk.css
[5/7] /usr/local/bin/sassc -a -M -t compact ../dark/gtk-3.0/gtk-contained-dark.scss dark/gtk-dark.css
[6/7] /usr/local/bin/sassc -a -M -t compact ../light/gtk-3.0/gtk-contained.scss light/gtk.css
ninja: build stopped: subcommand failed.
*** Error code 1

Stop.
make: stopped in /usr/ports/x11-themes/greybird-theme
=>> Cleaning up wrkdir
===>  Cleaning for greybird-theme-3.22.11
Comment 4 Guido Falsi freebsd_committer 2020-01-12 14:37:07 UTC
Created attachment 210659 [details]
patch that compiles

Sorry for the noise, I found the missing dependency: librsvg2.

Updated the patch including this one too.

Still testing though.
Comment 5 Olivier Duchateau 2020-01-12 15:33:39 UTC
(In reply to Guido Falsi from comment #4)

Yes librsvg2 provides pixbufloader (for SVG files).
Comment 6 commit-hook freebsd_committer 2020-01-12 17:08:04 UTC
A commit references this bug:

Author: madpilot
Date: Sun Jan 12 17:07:04 UTC 2020
New revision: 522820
URL: https://svnweb.freebsd.org/changeset/ports/522820

Log:
  - Update greybird-theme to 3.22.11

  PR:		243268
  Submitted by:	Olivier Duchateau <duchateau.olivier@gmail.com>

Changes:
  head/x11-themes/greybird-theme/Makefile
  head/x11-themes/greybird-theme/distinfo
  head/x11-themes/greybird-theme/files/
  head/x11-themes/greybird-theme/files/patch-dark_meson.build
  head/x11-themes/greybird-theme/files/patch-light_meson.build
  head/x11-themes/greybird-theme/pkg-plist
Comment 7 Guido Falsi freebsd_committer 2020-01-12 17:08:40 UTC
Committed. Thanks!