Bug 243270 - [NEW PORT] security/py-vici: Native Python interface for strongSwan's VICI protocol
Summary: [NEW PORT] security/py-vici: Native Python interface for strongSwan's VICI pr...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mateusz Piotrowski
URL:
Keywords: feature, needs-qa
Depends on:
Blocks: 243254
  Show dependency treegraph
 
Reported: 2020-01-11 15:17 UTC by Dries Michiels
Modified: 2020-01-31 16:29 UTC (History)
4 users (show)

See Also:


Attachments
pyvici.diff (2.41 KB, patch)
2020-01-11 15:18 UTC, Dries Michiels
no flags Details | Diff
pyciviv2.diff (3.54 KB, patch)
2020-01-11 15:26 UTC, Dries Michiels
no flags Details | Diff
pyvici3.diff (2.78 KB, patch)
2020-01-11 15:29 UTC, Dries Michiels
no flags Details | Diff
pyviciv4.diff (3.32 KB, patch)
2020-01-11 18:49 UTC, Dries Michiels
no flags Details | Diff
pyvici5.diff (3.33 KB, patch)
2020-01-11 18:50 UTC, Dries Michiels
no flags Details | Diff
pyvici6.diff (3.18 KB, patch)
2020-01-14 18:47 UTC, Dries Michiels
no flags Details | Diff
pyvici7.diff (3.17 KB, patch)
2020-01-20 18:22 UTC, Dries Michiels
no flags Details | Diff
Portlint results from py-vici port (10.23 KB, text/plain)
2020-01-21 09:16 UTC, strongswan
no flags Details
Poudriere testport results (18.14 KB, text/plain)
2020-01-21 09:17 UTC, strongswan
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dries Michiels 2020-01-11 15:17:39 UTC
This brings py-vici in the ports tree that provides a Native Python interface for strongSwan's VICI protocol.
Comment 1 Dries Michiels 2020-01-11 15:18:13 UTC
Created attachment 210623 [details]
pyvici.diff

Attach the patch for real now ..
Comment 2 Dries Michiels 2020-01-11 15:26:33 UTC
Created attachment 210624 [details]
pyciviv2.diff

Add py-vici under security/Makefile as new port.
Comment 3 Dries Michiels 2020-01-11 15:29:29 UTC
Created attachment 210625 [details]
pyvici3.diff

Leave out other diffs I had locally.
Comment 4 Dries Michiels 2020-01-11 18:49:54 UTC
Created attachment 210630 [details]
pyviciv4.diff

- Add tests
- Use GH to fetch source as PyPi does not include the test files

I created a PR to support running tests from setuptools with 
@${CD} ${WRKSRC} && ${PYTHON_CMD} ${PYDISTUTILS_SETUP} test

and to update their supported python versions in setup.py.
Tests seem to run fine in all versions (2.7, 3.5+).
Comment 5 Dries Michiels 2020-01-11 18:50:57 UTC
Created attachment 210631 [details]
pyvici5.diff
Comment 6 strongswan 2020-01-14 06:46:52 UTC
Thanks for the work thus far on the port.
I tested the build quickly and seems good.

Not sure if we should also add the 'net-vpn' category.
strongSwan is listed under security and net-vpn.
Comment 7 Dries Michiels 2020-01-14 16:13:06 UTC
Oh yes, good idea. Will update the patch in a few hours with upstream fixes.
Comment 8 Dries Michiels 2020-01-14 18:47:24 UTC
Created attachment 210740 [details]
pyvici6.diff

Updated with upstream changes.
- Use PyPi for master site 
- Use tox for tests

This is about as good as it gets :-)

All supported flavors build and run the tests fine.
portlint -ac = looks fine.
Comment 9 Dries Michiels 2020-01-20 18:22:00 UTC
Created attachment 210899 [details]
pyvici7.diff

Thanks to strongswan@Nanoteq.com for PM me to catch some spaces where there should be tabs with the capital verison of portlint -AC.
Comment 10 strongswan 2020-01-21 09:16:04 UTC
Created attachment 210909 [details]
Portlint results from py-vici port

I tested the py-vici port with portlint in conjunction with the strongSwan port.
Here is the portlint results.
Comment 11 strongswan 2020-01-21 09:17:07 UTC
Created attachment 210910 [details]
Poudriere testport results

This is the poudriere testport build results for py-vici.

Everything looks good to me on this port.
Comment 12 Mateusz Piotrowski freebsd_committer 2020-01-31 16:10:43 UTC
Take it!
Comment 13 commit-hook freebsd_committer 2020-01-31 16:26:35 UTC
A commit references this bug:

Author: 0mp
Date: Fri Jan 31 16:26:27 UTC 2020
New revision: 524726
URL: https://svnweb.freebsd.org/changeset/ports/524726

Log:
  New port: security/py-vici: Native Python interface for strongSwan's VICI protocol

  The strongSwan VICI protocol allows external applications to monitor,
  configure and control the IKE daemon charon.  This Python package provides
  a native client side implementation of the VICI protocol, well suited to
  script automated tasks in a reliable way.

  WWW: https://pypi.org/project/vici/

  Event:		Brussels DevSummit 2020
  PR:		243270
  Submitted by:	Dries Michiels <driesm.michiels@gmail.com>

Changes:
  head/security/py-vici/
  head/security/py-vici/Makefile
  head/security/py-vici/distinfo
  head/security/py-vici/pkg-descr
Comment 14 commit-hook freebsd_committer 2020-01-31 16:29:37 UTC
A commit references this bug:

Author: 0mp
Date: Fri Jan 31 16:28:52 UTC 2020
New revision: 524728
URL: https://svnweb.freebsd.org/changeset/ports/524728

Log:
  Hook security/py-vici to the build

  PR:		243270
  Submitted by:	Dries Michiels <driesm.michiels@gmail.com>

Changes:
  head/security/Makefile
Comment 15 Mateusz Piotrowski freebsd_committer 2020-01-31 16:29:58 UTC
Thanks!