Bug 243270 - [NEW PORT] security/py-vici: Native Python interface for strongSwan's VICI protocol
Summary: [NEW PORT] security/py-vici: Native Python interface for strongSwan's VICI pr...
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords: feature, needs-qa
Depends on:
Blocks: 243254
  Show dependency treegraph
 
Reported: 2020-01-11 15:17 UTC by Dries Michiels
Modified: 2020-01-20 18:22 UTC (History)
3 users (show)

See Also:


Attachments
pyvici.diff (2.41 KB, patch)
2020-01-11 15:18 UTC, Dries Michiels
no flags Details | Diff
pyciviv2.diff (3.54 KB, patch)
2020-01-11 15:26 UTC, Dries Michiels
no flags Details | Diff
pyvici3.diff (2.78 KB, patch)
2020-01-11 15:29 UTC, Dries Michiels
no flags Details | Diff
pyviciv4.diff (3.32 KB, patch)
2020-01-11 18:49 UTC, Dries Michiels
no flags Details | Diff
pyvici5.diff (3.33 KB, patch)
2020-01-11 18:50 UTC, Dries Michiels
no flags Details | Diff
pyvici6.diff (3.18 KB, patch)
2020-01-14 18:47 UTC, Dries Michiels
no flags Details | Diff
pyvici7.diff (3.17 KB, patch)
2020-01-20 18:22 UTC, Dries Michiels
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dries Michiels 2020-01-11 15:17:39 UTC
This brings py-vici in the ports tree that provides a Native Python interface for strongSwan's VICI protocol.
Comment 1 Dries Michiels 2020-01-11 15:18:13 UTC
Created attachment 210623 [details]
pyvici.diff

Attach the patch for real now ..
Comment 2 Dries Michiels 2020-01-11 15:26:33 UTC
Created attachment 210624 [details]
pyciviv2.diff

Add py-vici under security/Makefile as new port.
Comment 3 Dries Michiels 2020-01-11 15:29:29 UTC
Created attachment 210625 [details]
pyvici3.diff

Leave out other diffs I had locally.
Comment 4 Dries Michiels 2020-01-11 18:49:54 UTC
Created attachment 210630 [details]
pyviciv4.diff

- Add tests
- Use GH to fetch source as PyPi does not include the test files

I created a PR to support running tests from setuptools with 
@${CD} ${WRKSRC} && ${PYTHON_CMD} ${PYDISTUTILS_SETUP} test

and to update their supported python versions in setup.py.
Tests seem to run fine in all versions (2.7, 3.5+).
Comment 5 Dries Michiels 2020-01-11 18:50:57 UTC
Created attachment 210631 [details]
pyvici5.diff
Comment 6 strongswan 2020-01-14 06:46:52 UTC
Thanks for the work thus far on the port.
I tested the build quickly and seems good.

Not sure if we should also add the 'net-vpn' category.
strongSwan is listed under security and net-vpn.
Comment 7 Dries Michiels 2020-01-14 16:13:06 UTC
Oh yes, good idea. Will update the patch in a few hours with upstream fixes.
Comment 8 Dries Michiels 2020-01-14 18:47:24 UTC
Created attachment 210740 [details]
pyvici6.diff

Updated with upstream changes.
- Use PyPi for master site 
- Use tox for tests

This is about as good as it gets :-)

All supported flavors build and run the tests fine.
portlint -ac = looks fine.
Comment 9 Dries Michiels 2020-01-20 18:22:00 UTC
Created attachment 210899 [details]
pyvici7.diff

Thanks to strongswan@Nanoteq.com for PM me to catch some spaces where there should be tabs with the capital verison of portlint -AC.