Bug 243314 - games/scummvm doesn't build when FLUIDSYNTH is enabled
Summary: games/scummvm doesn't build when FLUIDSYNTH is enabled
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-13 10:38 UTC by Peter Kien
Modified: 2020-02-02 15:23 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (lme)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Kien 2020-01-13 10:38:26 UTC
The last couple of compilation messages were:

----------------
In file included from audio/softsynth/fluidsynth.cpp:38:
In file included from /usr/local/include/fluidsynth.h:97:
/usr/local/include/fluidsynth/synth.h:201:49: warning: commas at the end of enumerator lists are a C++11 extension [-Wc++11-extensions]
    FLUID_INTERP_HIGHEST = FLUID_INTERP_7THORDER, /**< Highest interpolation method */
                                                ^
/usr/local/include/fluidsynth/synth.h:247:20: warning: commas at the end of enumerator lists are a C++11 extension [-Wc++11-extensions]
    FLUID_SYNTH_ADD,              /**< Sum up modulator amounts */
                   ^~
/usr/local/include/fluidsynth/synth.h:325:34: warning: commas at the end of enumerator lists are a C++11 extension [-Wc++11-extensions]
    FLUID_CHANNEL_OMNI_OFF = 0x02, /**< if flag is set, the basic channel is in omni off state, if not set omni is on */
                                 ^
/usr/local/include/fluidsynth/synth.h:333:37: warning: commas at the end of enumerator lists are a C++11 extension [-Wc++11-extensions]
    FLUID_CHANNEL_BREATH_SYNC = 0x40,  /**< when channel is mono, this flag indicates that the breath controler(MSB)triggers noteon/noteoff on the running note */
                                    ^~
In file included from audio/softsynth/fluidsynth.cpp:38:
In file included from /usr/local/include/fluidsynth.h:105:
/usr/local/include/fluidsynth/log.h:82:25: error: expected ')'
__attribute__ ((format (printf, 2, 3)))
                        ^
./common/forbidden.h:62:16: note: expanded from macro 'printf'
#define printf  FORBIDDEN_SYMBOL_REPLACEMENT
                ^
./common/forbidden.h:57:89: note: expanded from macro 'FORBIDDEN_SYMBOL_REPLACEMENT'
#define FORBIDDEN_SYMBOL_REPLACEMENT    FORBIDDEN_look_at_common_forbidden_h_for_more_info SYMBOL !%*
                                                                                           ^
In file included from audio/softsynth/fluidsynth.cpp:38:
In file included from /usr/local/include/fluidsynth.h:105:
/usr/local/include/fluidsynth/log.h:82:25: error: expected ')'
./common/forbidden.h:62:16: note: expanded from macro 'printf'
#define printf  FORBIDDEN_SYMBOL_REPLACEMENT
                ^
./common/forbidden.h:57:96: note: expanded from macro 'FORBIDDEN_SYMBOL_REPLACEMENT'
#define FORBIDDEN_SYMBOL_REPLACEMENT    FORBIDDEN_look_at_common_forbidden_h_for_more_info SYMBOL !%*
                                                                                                  ^
In file included from audio/softsynth/fluidsynth.cpp:38:
In file included from /usr/local/include/fluidsynth.h:105:
/usr/local/include/fluidsynth/log.h:82:39: error: expected function body after function declarator
__attribute__ ((format (printf, 2, 3)))
                                      ^
In file included from audio/softsynth/fluidsynth.cpp:38:
In file included from /usr/local/include/fluidsynth.h:107:
/usr/local/include/fluidsynth/mod.h:54:25: warning: commas at the end of enumerator lists are a C++11 extension [-Wc++11-extensions]
    FLUID_MOD_SIN = 0x80,            /**< Custom non-standard sinus mapping function */
                        ^~
5 warnings and 3 errors generated.
gmake[1]: *** [Makefile.common:122: audio/softsynth/fluidsynth.o] Error 1
gmake[1]: *** Waiting for unfinished jobs....
gmake[1]: Leaving directory '/wrkdirs/usr/ports/games/scummvm/work/scummvm-2.1.0'
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make: stopped in /usr/ports/games/scummvm
-----------------

(I've already tried setting "-Wc++11-extensions", but to no avail.)
Comment 1 commit-hook freebsd_committer 2020-02-02 15:23:26 UTC
A commit references this bug:

Author: tobik
Date: Sun Feb  2 15:23:00 UTC 2020
New revision: 524970
URL: https://svnweb.freebsd.org/changeset/ports/524970

Log:
  games/scummvm: Unbreak build with FLUIDSYNTH=on

  In file included from audio/softsynth/fluidsynth.cpp:38:
  In file included from /usr/local/include/fluidsynth.h:105:
  /usr/local/include/fluidsynth/log.h:82:25: error: expected ')'
  __attribute__ ((format (printf, 2, 3)))
                          ^
  ./common/forbidden.h:62:16: note: expanded from macro 'printf'
  #define printf  FORBIDDEN_SYMBOL_REPLACEMENT
                  ^
  ./common/forbidden.h:57:89: note: expanded from macro 'FORBIDDEN_SYMBOL_REPLACEMENT'
  #define FORBIDDEN_SYMBOL_REPLACEMENT    FORBIDDEN_look_at_common_forbidden_h_for_more_info SYMBOL !%*
                                                                                             ^

  PR:		243314

Changes:
  head/games/scummvm/Makefile
  head/games/scummvm/distinfo
Comment 2 Tobias Kortkamp freebsd_committer 2020-02-02 15:23:43 UTC
I applied two upstream commits that should fix this.