Scenario: - Building ports using portmaster Result: - If there is a dependency on binutils, the latter always gets rebuilt even if it is up to date. - The same seems to be the case for py-sphinx and possibly other ports (maybe gperf) Expected result: - portmaster should not rebuild a port if it is up-to-date Maybe this is the case because the BUILD_DEPENDS+= line in ports/Mk/... includes the full path to the desired executable (i.e., "${LOCALBASE}/...")? -- Martin
Created attachment 210855 [details] patch-portmaster-flavors Please, try this patch. (Only tested quick with a few ports - binutils, gcc9, cmake).
Just trying this now, first with the unpatched and now with the patched version of portmaster, and it seems to work - the unpatched version again tried to recompile binutils, the patched version does not. So thanks! -- Martin
A commit references this bug: Author: se Date: Tue Jan 21 21:05:20 UTC 2020 New revision: 523745 URL: https://svnweb.freebsd.org/changeset/ports/523745 Log: Attempt to fix a problem that leads to repeated building of some ports There are build dependencies, that were compiled again and again even though the latest version was already installed. This fix is based on a patch suggested by Tatsuki Makino, with a small change to better comply with the existing style used in this program. An extended patch has been provided by Walter Schwarzenfeld, but in my tests it did not make a difference. If further testing shows a need for the additional commands suggested by Walter, I'll add them (or a variation) in a follow-up commit. PR: 241227, 242086, 243432 Submitted by: Tatsuki Makino Approved by: antoine (implicit) Changes: head/ports-mgmt/portmaster/Makefile head/ports-mgmt/portmaster/files/patch-portmaster
Seems to work after ports r523835.
Thank you for committing the fix, it seems to work! -- Martin