Bug 243447 - [MAINTAINER UPDATE] [PATCH] Update astro/opencpn to 5.0.0 (and make it fetchable again)
Summary: [MAINTAINER UPDATE] [PATCH] Update astro/opencpn to 5.0.0 (and make it fetcha...
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2020-01-19 14:51 UTC by ml
Modified: 2020-01-21 11:35 UTC (History)
1 user (show)

See Also:


Attachments
SVN diff (153.43 KB, patch)
2020-01-19 14:51 UTC, ml
no flags Details | Diff
Revised SVN diff (153.42 KB, patch)
2020-01-21 11:35 UTC, ml
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ml 2020-01-19 14:51:22 UTC
Created attachment 210865 [details]
SVN diff
Comment 1 Automation User 2020-01-19 21:08:57 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/110564253
Comment 2 Tobias C. Berner freebsd_committer 2020-01-19 21:17:01 UTC
Moin moin

Instead of adding  -DBUNDLE_TCDATA=ON -DOCPN_NEW_SERIAL=OFF -DOCPN_FORCE_GTK3=ON to cmake args, you can use the helpers CMAKE_ON and CMAKE_OFF

CMAKE_ON=BUNDLE_TCDATA OPCN_FORCE_GTK3
CMAKE_OFF=OCPN_NEW_SERIAL

PREFIX in your CFLAGS like
-I${PREFIX}/include/gdk-pixbuf-2.0
should be LOCALBASE.

Followup question: does the cmake of the project not look for these, why do you need to manually add them to CLFAGS/LDFLAGS? Are you missing USES=pkgconfig?


DOCS_CMAKE_ON=	-DBUNDLE_DOCS=ON
DOCS_CMAKE_OFF=	-DBUNDLE_DOCS=OFF

can be reduced to 
DOCS_CMAKE_BOOL=BUNDLE_DOCS


mfg Tobias
Comment 3 Tobias C. Berner freebsd_committer 2020-01-19 21:19:42 UTC
%%DOCS%%%%DATADIR%%/doc/getting_started/opencpn_installation/%%CMAKE_BUILD_TYPE%%_history.html

looks like a wrong use of the CMAKE_BUILD_TYPE-sub
Comment 4 ml 2020-01-21 11:32:26 UTC
Sorry!
I create the plist automatically, checked and modified it, but this slipped through.

I'm attaching an updated svn diff.
Comment 5 ml 2020-01-21 11:35:03 UTC
Created attachment 210912 [details]
Revised SVN diff