Bug 243481 - net-p2p/c-lightning: fix build on GCC architectures
Summary: net-p2p/c-lightning: fix build on GCC architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Vasil Dimov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-21 09:23 UTC by Piotr Kubaj
Modified: 2020-01-21 10:50 UTC (History)
1 user (show)

See Also:
vd: maintainer-feedback+
pkubaj: merge-quarterly?


Attachments
patch (1.35 KB, patch)
2020-01-21 09:23 UTC, Piotr Kubaj
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2020-01-21 09:23:09 UTC
Created attachment 210911 [details]
patch

Needs C11 compiler:
cc1: error: unrecognized command line option "-std=gnu11"

Needs include sys/types.h in fdpass.c:
ccan/ccan/fdpass/fdpass.c: In function 'fdpass_send':
ccan/ccan/fdpass/fdpass.c:16:12: error: 'register_t' undeclared (first use in this function)
   16 |   char buf[CMSG_SPACE(sizeof(fd))];
      |            ^~~~~~~~~~

This fixes build with GCC.
Comment 1 Vasil Dimov freebsd_committer 2020-01-21 10:28:46 UTC
LGTM, thanks!
Comment 2 commit-hook freebsd_committer 2020-01-21 10:49:03 UTC
A commit references this bug:

Author: pkubaj
Date: Tue Jan 21 10:48:59 UTC 2020
New revision: 523712
URL: https://svnweb.freebsd.org/changeset/ports/523712

Log:
  net-p2p/c-lightning: fix build on GCC architectures

  Needs C11 compiler:
  cc1: error: unrecognized command line option "-std=gnu11"

  Needs include sys/types.h in fdpass.c:
  ccan/ccan/fdpass/fdpass.c: In function 'fdpass_send':
  ccan/ccan/fdpass/fdpass.c:16:12: error: 'register_t' undeclared (first use in this function)
     16 |   char buf[CMSG_SPACE(sizeof(fd))];
        |            ^~~~~~~~~~

  PR:		243481
  Approved by:	vd (maintainer)
  MFH:		2020Q1 (fix build blanket)

Changes:
  head/net-p2p/c-lightning/Makefile
  head/net-p2p/c-lightning/files/patch-ccan_ccan_fdpass_fdpass.c
Comment 3 commit-hook freebsd_committer 2020-01-21 10:50:04 UTC
A commit references this bug:

Author: pkubaj
Date: Tue Jan 21 10:50:00 UTC 2020
New revision: 523713
URL: https://svnweb.freebsd.org/changeset/ports/523713

Log:
  MFH: r523712

  net-p2p/c-lightning: fix build on GCC architectures

  Needs C11 compiler:
  cc1: error: unrecognized command line option "-std=gnu11"

  Needs include sys/types.h in fdpass.c:
  ccan/ccan/fdpass/fdpass.c: In function 'fdpass_send':
  ccan/ccan/fdpass/fdpass.c:16:12: error: 'register_t' undeclared (first use in this function)
     16 |   char buf[CMSG_SPACE(sizeof(fd))];
        |            ^~~~~~~~~~

  PR:		243481
  Approved by:	vd (maintainer)

  Approved by:	portmgr (fix build blanket)

Changes:
_U  branches/2020Q1/
  branches/2020Q1/net-p2p/c-lightning/Makefile
  branches/2020Q1/net-p2p/c-lightning/files/patch-ccan_ccan_fdpass_fdpass.c