Bug 244391 - dns/bind916: Option TUNING_LARGE is obsolete
Summary: dns/bind916: Option TUNING_LARGE is obsolete
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Mathieu Arnold
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-25 04:36 UTC by Greg Rivers
Modified: 2020-08-26 13:32 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (mat)


Attachments
bind916 new defaults (2.33 KB, patch)
2020-02-25 11:20 UTC, Leo Vandewoestijne
no flags Details | Diff
tuning small (1.43 KB, patch)
2020-07-01 22:52 UTC, Leo Vandewoestijne
no flags Details | Diff
tuning removed (1.33 KB, patch)
2020-07-01 22:53 UTC, Leo Vandewoestijne
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Rivers 2020-02-25 04:36:04 UTC
Per the BIND 9.16 ARM page 309:

•Compile-time settings enabled by the --with-tuning=large option for configure are now in effect by default. Previously used default compile-time settings can be enabled by passing --with-tuning=small to configure. [GL !2989]

The TUNING_LARGE port option should be changed to TUNING_SMALL, and should be OFF by default.
Comment 1 Leo Vandewoestijne 2020-02-25 09:40:45 UTC
Same for LARGE_FILE; it swapped around also; it's now

  --disable-largefile     omit support for large files


And also for GeoIP it now seems turned the other way around

  --disable-geoip         support GeoIP2 geolocation ACLs if available
                          [default=yes]
  --with-geoip2           deprecated, use --with-maxminddb
  --with-maxminddb=PATH   Build with MaxMind GeoIP2 support (auto|yes|no|path)
                          [default=auto]
Comment 2 Leo Vandewoestijne 2020-02-25 11:20:26 UTC
Created attachment 211923 [details]
bind916 new defaults

My attempt to address it all.
Comment 3 Leo Vandewoestijne 2020-02-26 13:10:41 UTC
Comment on attachment 211923 [details]
bind916 new defaults

On second thought...
Since the history of geoip / the new defaults,
then maybe it wont hurt to change

GEOIP_CONFIGURE_OFF=		--disable-geoip

to

GEOIP_CONFIGURE_OFF=		--disable-geoip \
                                --without-geoip2 \
                                --without-maxminddb
Comment 4 Greg Rivers 2020-02-26 19:26:14 UTC
(In reply to Leo Vandewoestijne from comment #1)
Good catch on these other options.
Comment 5 Greg Rivers 2020-02-26 19:28:28 UTC
Mathieu, while we're here, can we also visit #237861 from last May?
Comment 6 Greg Rivers 2020-02-26 19:36:50 UTC
bug #237861
Comment 7 Leo Vandewoestijne 2020-03-01 21:07:17 UTC
Another "problem" in the OPTIONS that I noticed is that you can't have the isc python module without installing bind-tools.
Something which is not needed if you don't removing the PYTHON option.
Comment 8 Mathieu Arnold freebsd_committer 2020-03-18 21:02:42 UTC
(In reply to Leo Vandewoestijne from comment #7)

I don't understand the problem you have with the Python option, it only exists with bind-tools. (and you cannot install bind916 without installing bind-tools.)
Comment 9 Leo Vandewoestijne 2020-03-19 08:18:27 UTC
(In reply to Mathieu Arnold from comment #8)
I wish to have python without having the bind-tools - which is possible, and just a matter of the adaption I made.
If you however think that overcomplicates, then installing bind tools is a reasonable compromis.
Comment 10 Mathieu Arnold freebsd_committer 2020-03-19 10:03:48 UTC
So, let me explain a bit more.

The "things" that are enabled by the PYTHON options are only command line tools.

The BIND9 software is splitted into two ports.
The first part is the command line tools, dig, delv, nsupdate, dnssec-keygen...
The second part is the server part, which is in one of the bind911, bind914, bind916 and bind9-devel

It makes no sense to enable the PYTHON option for the server ports, it would not install or build anything,
Comment 11 Leo Vandewoestijne 2020-03-19 13:07:29 UTC
(In reply to Mathieu Arnold from comment #10)
I think the d in rndc stands for daemon and the c for control.
The python module contains isc.rndc
It's useful to add/delete zones and other daemon control.
And faster than executing seperate system commands.

So I desire none of the tools you sum up, but want python able to control my daemon.
Right now I take the tools for granted, but they aren't needed, as the bind port could also install the python module.
Comment 12 Leo Vandewoestijne 2020-07-01 22:52:49 UTC
Created attachment 216119 [details]
tuning small

Too much issues addressed at once?
In that case let's breakdown in parts. So by these:
 - one patch to either adjust the tuning option, or
 - another to remove the option entirely.

Despite the mutation being super-simple I still tested them (successfully) in poudriere.
Comment 13 Leo Vandewoestijne 2020-07-01 22:53:56 UTC
Created attachment 216120 [details]
tuning removed

The patch to remove the option entirely.
Comment 14 commit-hook freebsd_committer 2020-08-26 13:32:43 UTC
A commit references this bug:

Author: mat
Date: Wed Aug 26 13:32:18 UTC 2020
New revision: 546281
URL: https://svnweb.freebsd.org/changeset/ports/546281

Log:
  Remove the TUNING_LARGE option, it is now a no-op.

  PR:		244391
  Submitted by:	Leo Vandewoestijne

Changes:
  head/dns/bind9-devel/Makefile
  head/dns/bind9-devel/pkg-help
  head/dns/bind916/Makefile
  head/dns/bind916/pkg-help