Bug 244504 - devel/glslang: Fix build with clang 10.0.0
Summary: devel/glslang: Fix build with clang 10.0.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks: 244251
  Show dependency tree / graph
 
Reported: 2020-02-28 17:32 UTC by Dimitry Andric
Modified: 2020-02-28 20:19 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (val)

Attachments
Fix devel/glslang build with clang 10.0.0 (1.46 KB, patch)
2020-02-28 17:32 UTC, Dimitry Andric 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2020-02-28 17:32:16 UTC 
Created attachment 212028 [details]
Fix devel/glslang build with clang 10.0.0

As reported in bug 244251, with clang 10.0.0 the devel/glslang port fails to build with:

In file included from MachineIndependent/glslang.y:60:
In file included from /wrkdirs/usr/ports/devel/glslang/work/glslang-7.11.3214/glslang/MachineIndependent/SymbolTable.h:68:
In file included from /wrkdirs/usr/ports/devel/glslang/work/glslang-7.11.3214/glslang/MachineIndependent/../Include/Common.h:108:
/wrkdirs/usr/ports/devel/glslang/work/glslang-7.11.3214/glslang/MachineIndependent/../Include/PoolAlloc.h:307:54: error: 'operator=' is a private member of 'glslang::TPoolAllocator'
    void setAllocator(TPoolAllocator* a) { allocator = *a; }
                                           ~~~~~~~~~ ^ ~~
/wrkdirs/usr/ports/devel/glslang/work/glslang-7.11.3214/glslang/MachineIndependent/../Include/PoolAlloc.h:244:21: note: declared private here
    TPoolAllocator& operator=(const TPoolAllocator&);  // don't allow assignment operator
                    ^
1 error generated.

This can be fixed by applying an upstream commit from the glslang project:
https://github.com/KhronosGroup/glslang/commit/24b3e8384e93f3e73b6aa14ea00a30574112f9ba
Comment 1 Jan Beich freebsd_committer freebsd_triage 2020-02-28 19:54:30 UTC 
Did you see ports r527179?
Comment 2 Dimitry Andric freebsd_committer freebsd_triage 2020-02-28 20:19:18 UTC 
Ah, I hadn't updated my tree for a few days, so thanks!