Bug 245068 - cad/lepton-eda: Update to 1.9.10
Summary: cad/lepton-eda: Update to 1.9.10
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2020-03-26 06:13 UTC by dmn
Modified: 2020-03-27 15:26 UTC (History)
1 user (show)

See Also:


Attachments
cad/lepton-eda: Update to 1.9.10 (49.46 KB, patch)
2020-03-26 06:13 UTC, dmn
graahnul.grom: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description dmn 2020-03-26 06:13:56 UTC
Created attachment 212719 [details]
cad/lepton-eda: Update to 1.9.10

The Lepton EDA suite version 1.9.10 has been released.
There are many changes and fixes, please see the NEWS.md file[1].

The port itself has been simplified:
- finally, we got rid of dependency on Python! :-)
- greatly reduced number of patches
- rarely changed files that needs to be patched are now
  modified in the 'post-patch' target in the Makefile

[1] https://github.com/lepton-eda/lepton-eda/blob/master/NEWS.md

Best regards,
Dmitry.
Comment 1 Automation User 2020-03-26 07:12:29 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/129846002
Comment 2 Fernando Apesteguía freebsd_committer 2020-03-26 08:41:13 UTC
^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval

Attachment -> Details -> maintainer-approval [+]
Comment 3 dmn 2020-03-26 10:02:42 UTC
(In reply to Fernando Apesteguía from comment #2)

Please excuse my ignorance, but do I have to set this flag even if the patch was posted by me (port maintainer), and not someone else?
Thank you.
Comment 4 Fernando Apesteguía freebsd_committer 2020-03-26 10:36:44 UTC
(In reply to dmn from comment #3)

Yes please, it helps keeping the PR database in good health :-)

Thanks!
Comment 5 commit-hook freebsd_committer 2020-03-27 07:26:01 UTC
A commit references this bug:

Author: fernape
Date: Fri Mar 27 07:25:18 UTC 2020
New revision: 529231
URL: https://svnweb.freebsd.org/changeset/ports/529231

Log:
  cad/lepton-eda: Update to 1.9.10

  ChangeLog:
  https://github.com/lepton-eda/lepton-eda/blob/master/NEWS.md#notable-changes-in-lepton-eda-1910-20200319

  PR:     245068
  Submitted by:   graahnul.grom@gmail.com (maintainer)

Changes:
  head/cad/lepton-eda/Makefile
  head/cad/lepton-eda/distinfo
  head/cad/lepton-eda/files/patch-build-tools_icon-theme-installer
  head/cad/lepton-eda/files/patch-docs_scheme-api_Makefile.am
  head/cad/lepton-eda/files/patch-examples_Makefile.am
  head/cad/lepton-eda/files/patch-examples_RF__Amp_Makefile.am
  head/cad/lepton-eda/files/patch-examples_RF__Amp_model_Makefile.am
  head/cad/lepton-eda/files/patch-examples_RF__Amp_sym_Makefile.am
  head/cad/lepton-eda/files/patch-examples_TwoStageAmp_Makefile.am
  head/cad/lepton-eda/files/patch-examples_gTAG_Makefile.am
  head/cad/lepton-eda/files/patch-examples_lightning__detector_Makefile.am
  head/cad/lepton-eda/files/patch-liblepton_include_liblepton_geda__list.h
  head/cad/lepton-eda/files/patch-liblepton_scheme_geda_log-rotate.scm
  head/cad/lepton-eda/files/patch-liblepton_scheme_geda_os.scm
  head/cad/lepton-eda/files/patch-liblepton_src_geda__list.c
  head/cad/lepton-eda/files/patch-liblepton_src_scheme__os.c
  head/cad/lepton-eda/files/patch-netlist_scheme_backend_gnet-spice-sdb.scm
  head/cad/lepton-eda/files/patch-schematic_src_x__tabs.c
  head/cad/lepton-eda/files/patch-utils_scripts_lepton-upcfg.in
  head/cad/lepton-eda/files/patch-version.h
  head/cad/lepton-eda/pkg-descr
  head/cad/lepton-eda/pkg-plist
Comment 6 Fernando Apesteguía freebsd_committer 2020-03-27 07:31:27 UTC
Since the port is not using Python2.7 anymore... what about removing the DEPRECATED block? :-)
Comment 7 dmn 2020-03-27 11:22:43 UTC
(In reply to Fernando Apesteguía from comment #6)

Thank you, Fernando!
Removing of the DEPRECATED block would be a right thing to do.
But how do I do it? Again, please do not blame me for not being
an expert in the Ports Collection machinery. I will learn. :-)
Comment 8 Fernando Apesteguía freebsd_committer 2020-03-27 11:26:55 UTC
(In reply to dmn from comment #7)

No worries :)

Have a look at https://www.freebsd.org/doc/en/books/porters-handbook/book.html#dads-deprecated

Since the port already has a fix, the DEPRECATE reason is valid no more. We can just delete that block from the Makefile since we already applied a fix.

I'll do it for you. No need to send a new patch.
Comment 9 commit-hook freebsd_committer 2020-03-27 12:11:23 UTC
A commit references this bug:

Author: fernape
Date: Fri Mar 27 12:10:29 UTC 2020
New revision: 529242
URL: https://svnweb.freebsd.org/changeset/ports/529242

Log:
  cad/lepton-eda: remove DEPRECATE block

  The port dropped python2.7 dependency in r529231

  PR:	245068

Changes:
  head/cad/lepton-eda/Makefile
Comment 10 Fernando Apesteguía freebsd_committer 2020-03-27 12:13:44 UTC
Committed,

Thanks!
Comment 11 dmn 2020-03-27 15:26:28 UTC
Dear Fernando! Let me express my gratitude for your professional response to my humble bug report and your kind attitude towards me. I wish you all the best, and please take care in these times of collective madness. :-) ¡muchas gracias!