Bug 245125 - [PATCH] Typo in hccontrol/le.c
Summary: [PATCH] Typo in hccontrol/le.c
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: wireless (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Ed Maste
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-28 12:26 UTC by Marc Veldman
Modified: 2020-04-25 15:48 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Veldman 2020-03-28 12:26:41 UTC 
I found a small typo in hccontrol (disble/disable):

marc@devnovo:/usr/src/usr.sbin/bluetooth/hccontrol $ hccontrol le_enable disable
Using HCI node: ubt0hci
Usage: le_enable
le_enable [enable|disable] 
Enable LE event 
marc@devnovo:/usr/src/usr.sbin/bluetooth/hccontrol $ hccontrol le_enable disble
Using HCI node: ubt0hci


Patch below should fix it.

Index: usr.sbin/bluetooth/hccontrol/le.c
===================================================================
--- usr.sbin/bluetooth/hccontrol/le.c	(revision 359389)
+++ usr.sbin/bluetooth/hccontrol/le.c	(working copy)
@@ -306,7 +306,7 @@
 		set_event_mask(s, NG_HCI_EVENT_MASK_DEFAULT |
 			       NG_HCI_EVENT_MASK_LE);
 		set_le_event_mask(s, NG_HCI_LE_EVENT_MASK_ALL);
-	} else if (strcasecmp(argv[0], "disble") == 0)
+	} else if (strcasecmp(argv[0], "disable") == 0)
 		set_event_mask(s, NG_HCI_EVENT_MASK_DEFAULT);
 	else
 		return USAGE;
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-03-30 17:46:56 UTC 
A commit references this bug:

Author: emaste
Date: Mon Mar 30 17:38:13 UTC 2020
New revision: 359449
URL: https://svnweb.freebsd.org/changeset/base/359449

Log:
  correct 'disble' typo in hccontrol

  PR:		245125
  Submitted by:	Marc Veldman
  MFC after:	1 week

Changes:
  head/usr.sbin/bluetooth/hccontrol/le.c
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-04-25 15:44:30 UTC 
A commit references this bug:

Author: emaste
Date: Sat Apr 25 15:43:44 UTC 2020
New revision: 360315
URL: https://svnweb.freebsd.org/changeset/base/360315

Log:
  MFC r359449: correct 'disble' typo in hccontrol

  PR:		245125
  Submitted by:	Marc Veldman

Changes:
_U  stable/12/
  stable/12/usr.sbin/bluetooth/hccontrol/le.c
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-04-25 15:44:31 UTC 
A commit references this bug:

Author: emaste
Date: Sat Apr 25 15:44:25 UTC 2020
New revision: 360316
URL: https://svnweb.freebsd.org/changeset/base/360316

Log:
  MFC r359449: correct 'disble' typo in hccontrol

  PR:		245125
  Submitted by:	Marc Veldman

Changes:
_U  stable/11/
  stable/11/usr.sbin/bluetooth/hccontrol/le.c