Bug 245354 - [Patch] hccontrol features list incomplete/out of date
Summary: [Patch] hccontrol features list incomplete/out of date
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: wireless (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Hans Petter Selasky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-04 17:50 UTC by Marc Veldman
Modified: 2020-05-18 08:43 UTC (History)
2 users (show)

See Also:


Attachments
Adds possible features to hci_features2str() (3.39 KB, patch)
2020-04-04 17:50 UTC, Marc Veldman
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Veldman 2020-04-04 17:50:55 UTC
Created attachment 213068 [details]
Adds possible features to hci_features2str()

The list of possible features in hccontrol/features2str() is incomplete.

Attached patch brings the list more up-to-date.
The patch also enlarges buffers for users of hci_features2str
since it can return a significantly larger string.

Source: Bluetooth Core Specification 5.2 Vol. 2 Part C. 3.3 Feature Mask Definition.

Before:

marc@supernovo:~ % hccontrol -n ubt0hci read_local_supported_features
Features: 0xbf 0xfe 0xf 0xfe 0xdb 0xff 0x7b 0x87 
<3-Slot> <5-Slot> <Encryption> <Slot offset>
<Timing accuracy> <Switch> <Sniff mode> <RSSI>
<Channel quality> <SCO link> <HV2 packets> <HV3 packets>
<u-law log> <A-law log> <CVSD> <Paging scheme>
<Power control> <Transparent SCO data> 

After:
marc@devnovo:~ $ hccontrol -n ubt0hci read_local_supported_features
Features: 0xff 0xff 0x8f 0xfe 0xdb 0xff 0x5b 0x87 
<3-Slot> <5-Slot> <Encryption> <Slot offset>
<Timing accuracy> <Switch> <Hold mode> <Sniff mode>
<Park mode> <RSSI> <Channel quality> <SCO link>
<HV2 packets> <HV3 packets> <u-law log> <A-law log> <CVSD>
<Paging scheme> <Power control> <Transparent SCO data>
<Broadcast Encryption> <EDR ACL 2 Mb/s> <EDR ACL 3 Mb/s>
<Enhanced inquiry scan> <Interlaced inquiry scan>
<Interlaced page scan> <RSSI with inquiry results>
<Extended SCO link (EV3 packets)> <EV4 packets>
<EV5 packets> <AFH capable slave>
<AFH classification slave> <LE Supported (Controller)>
<3-Slot EDR ACL packets> <5-Slot EDR ACL packets>
<Sniff subrating> <Pause encryption> <AFH capable master>
<AFH classification master> <EDR eSCO 2 Mb/s mode>
<EDR eSCO 3 Mb/s mode> <3-Slot EDR eSCO packets>
<Enhanced Inquiry Response>
<Simultaneous LE and BR/EDR (Controller)>
<Secure Simple Pairing (Controller Support)>
<Encapsulated PDU> <Non-flushable Packed Boundary Flag>
<HCI_Link_Supervision_Timeout_Changed event>
<Variable Inquiry TX Power Level> <Enhanced Power Control>
<Extended features>
Comment 1 Kurt Jaeger freebsd_committer 2020-04-18 08:08:54 UTC
Looks interesting. Now we have to find a src committer that can approve/commit this.
Comment 2 Hans Petter Selasky freebsd_committer 2020-04-18 08:25:17 UTC
I'll take it. Looks good!
Comment 3 commit-hook freebsd_committer 2020-04-18 08:29:53 UTC
A commit references this bug:

Author: hselasky
Date: Sat Apr 18 08:29:18 UTC 2020
New revision: 360070
URL: https://svnweb.freebsd.org/changeset/base/360070

Log:
  Add missing feature descriptions to hci_features2str().

  The list of possible features in hccontrol/features2str() is incomplete.
  Refer to "Bluetooth Core Specification 5.2 Vol. 2 Part C. 3.3 Feature Mask Definition".

  Submitted by:	Marc Veldman <marc@bumblingdork.com>
  PR:		245354
  MFC after:	1 week
  Sponsored by:	Mellanox Technologies

Changes:
  head/usr.sbin/bluetooth/hccontrol/info.c
  head/usr.sbin/bluetooth/hccontrol/link_control.c
  head/usr.sbin/bluetooth/hccontrol/node.c
  head/usr.sbin/bluetooth/hccontrol/util.c
Comment 4 Hans Petter Selasky freebsd_committer 2020-04-18 08:30:06 UTC
Let us know if you have more patches for bluetooth.

Thank you!

--HPS
Comment 5 Marc Veldman 2020-04-18 09:09:56 UTC
I plan on doing some more work on bluetooth and hccontrol.
What is the best way: Make a PR and post it on -current?
I've posted this PR before on -bluetooth, but that list seems
very quiet.
Comment 6 Hans Petter Selasky freebsd_committer 2020-04-18 09:23:01 UTC
For small changes use bugzilla. Else upload patch with full context to differential revision.

--HPS
Comment 7 Kurt Jaeger freebsd_committer 2020-04-18 09:23:34 UTC
(In reply to Marc Veldman from comment #5)
Please submit PRs here or reviews on reviews.freebsd.org and add me or hselasky to the PR/review.
Comment 8 commit-hook freebsd_committer 2020-05-18 08:41:24 UTC
A commit references this bug:

Author: hselasky
Date: Mon May 18 08:40:40 UTC 2020
New revision: 361152
URL: https://svnweb.freebsd.org/changeset/base/361152

Log:
  MFC r360070:
  Add missing feature descriptions to hci_features2str().

  The list of possible features in hccontrol/features2str() is incomplete.
  Refer to "Bluetooth Core Specification 5.2 Vol. 2 Part C. 3.3 Feature Mask Definition".

  Submitted by:	Marc Veldman <marc@bumblingdork.com>
  PR:		245354
  Sponsored by:	Mellanox Technologies

Changes:
_U  stable/12/
  stable/12/usr.sbin/bluetooth/hccontrol/info.c
  stable/12/usr.sbin/bluetooth/hccontrol/link_control.c
  stable/12/usr.sbin/bluetooth/hccontrol/node.c
  stable/12/usr.sbin/bluetooth/hccontrol/util.c
Comment 9 commit-hook freebsd_committer 2020-05-18 08:42:26 UTC
A commit references this bug:

Author: hselasky
Date: Mon May 18 08:42:11 UTC 2020
New revision: 361153
URL: https://svnweb.freebsd.org/changeset/base/361153

Log:
  MFC r360070:
  Add missing feature descriptions to hci_features2str().

  The list of possible features in hccontrol/features2str() is incomplete.
  Refer to "Bluetooth Core Specification 5.2 Vol. 2 Part C. 3.3 Feature Mask Definition".

  Submitted by:	Marc Veldman <marc@bumblingdork.com>
  PR:		245354
  Sponsored by:	Mellanox Technologies

Changes:
_U  stable/11/
  stable/11/usr.sbin/bluetooth/hccontrol/info.c
  stable/11/usr.sbin/bluetooth/hccontrol/link_control.c
  stable/11/usr.sbin/bluetooth/hccontrol/node.c
  stable/11/usr.sbin/bluetooth/hccontrol/util.c
Comment 10 commit-hook freebsd_committer 2020-05-18 08:43:27 UTC
A commit references this bug:

Author: hselasky
Date: Mon May 18 08:43:06 UTC 2020
New revision: 361154
URL: https://svnweb.freebsd.org/changeset/base/361154

Log:
  MFC r360070:
  Add missing feature descriptions to hci_features2str().

  The list of possible features in hccontrol/features2str() is incomplete.
  Refer to "Bluetooth Core Specification 5.2 Vol. 2 Part C. 3.3 Feature Mask Definition".

  Submitted by:	Marc Veldman <marc@bumblingdork.com>
  PR:		245354
  Sponsored by:	Mellanox Technologies

Changes:
_U  stable/10/
  stable/10/usr.sbin/bluetooth/hccontrol/info.c
  stable/10/usr.sbin/bluetooth/hccontrol/link_control.c
  stable/10/usr.sbin/bluetooth/hccontrol/node.c
  stable/10/usr.sbin/bluetooth/hccontrol/util.c