Bug 245364 - devel/caf: fix build on GCC architectures
Summary: devel/caf: fix build on GCC architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Craig Leres
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-05 00:52 UTC by Piotr Kubaj
Modified: 2020-04-05 03:03 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (leres)
pkubaj: merge-quarterly?

Attachments
patch (3.00 KB, patch)
2020-04-05 00:52 UTC, Piotr Kubaj 		leres: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2020-04-05 00:52:27 UTC 
Created attachment 213078 [details]
patch

Some files require including sys/types.h before other headers:
/usr/include/netinet/ip.h:227:2: error: 'u_short' does not name a type; did you mean 'short'?
  227 |  u_short  ippseudo_len; /* protocol length */
      |  ^~~~~~~
      |  short
Comment 1 Craig Leres freebsd_committer freebsd_triage 2020-04-05 00:59:07 UTC 
Comment on attachment 213078 [details]
patch

Too funny, I'm literally in the process of updating my 13.0-CURRENT box so I could look at this...

I suspect upstream is *not* using clang 10.0 yet.

Anyway: approved. Also approved, please take maintainership, I no longer have anything that depends on this.
Comment 2 Piotr Kubaj freebsd_committer freebsd_triage 2020-04-05 02:59:02 UTC 
Committed. I don't really use this, so I won't maintain it.

Just to clarify - this patch was for compiling with GCC, not with Clang 10, since you probably misunderstood.
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-04-05 03:03:40 UTC 
A commit references this bug:

Author: pkubaj
Date: Sun Apr  5 02:56:11 UTC 2020
New revision: 530742
URL: https://svnweb.freebsd.org/changeset/ports/530742

Log:
  devel/caf: fix build on GCC architectures

  Some files require including sys/types.h before other headers:
  /usr/include/netinet/ip.h:227:2: error: 'u_short' does not name a type; did you mean 'short'?
    227 |  u_short  ippseudo_len; /* protocol length */
        |  ^~~~~~~
        |  short

  PR:		245364
  Approved by:	leres (maintainer)
  MFH:		2020Q2 (build fix blanket)

Changes:
  head/devel/caf/files/
  head/devel/caf/files/patch-libcaf__io_src_io_network_default__multiplexer.cpp
  head/devel/caf/files/patch-libcaf__io_src_io_network_ip__endpoint.cpp
  head/devel/caf/files/patch-libcaf__io_src_io_network_native__socket.cpp
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-04-05 03:03:43 UTC 
A commit references this bug:

Author: pkubaj
Date: Sun Apr  5 02:57:42 UTC 2020
New revision: 530743
URL: https://svnweb.freebsd.org/changeset/ports/530743

Log:
  MFH: r530742

  devel/caf: fix build on GCC architectures

  Some files require including sys/types.h before other headers:
  /usr/include/netinet/ip.h:227:2: error: 'u_short' does not name a type; did you mean 'short'?
    227 |  u_short  ippseudo_len; /* protocol length */
        |  ^~~~~~~
        |  short

  PR:		245364
  Approved by:	leres (maintainer)
  Approved by:	portmgr (fix build blanket)

Changes:
_U  branches/2020Q2/
  branches/2020Q2/devel/caf/files/