Bug 245621 - devel/py-msgpack: Update to 1.0.0
Summary: devel/py-msgpack: Update to 1.0.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-14 19:10 UTC by Namkhai B.
Modified: 2020-11-12 13:45 UTC (History)
1 user (show)

See Also:
nk: maintainer-feedback? (sunpoet)

Attachments
Update devel/py-msgpack to 1.0.0 (804 bytes, patch)
2020-04-14 19:10 UTC, Namkhai B. 		no flags Details | Diff
Update devel/py-msgpack to 1.0.0 (1.06 KB, patch)
2020-07-13 20:33 UTC, Namkhai B. 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Namkhai B. 2020-04-14 19:10:06 UTC 
Created attachment 213393 [details]
Update devel/py-msgpack to 1.0.0
Comment 1 Po-Chuan Hsieh freebsd_committer freebsd_triage 2020-07-11 11:16:00 UTC 
This patch does not work for py27 flavor. msgpack 1.0.0 drops python 2.7 support for msgpack/_cmsgpack.
Comment 2 Namkhai B. 2020-07-13 20:33:26 UTC 
Created attachment 216423 [details]
Update devel/py-msgpack to 1.0.0

Strip _cmsgpack only when building on Python 3
Comment 3 Namkhai B. 2020-07-13 20:39:06 UTC 
(In reply to Sunpoet Po-Chuan Hsieh from comment #1)

By the way, msgpack 1.0.0 _does_ support Python 2, but using the fallback implementation in pure python: https://github.com/msgpack/msgpack-python#pure-python-implementation

Is there any way to depend on lang/cython only when building for Python 3?
The Python 2 version builds and runs fine without cython.
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2020-11-12 13:45:16 UTC 
Update to 1.0.0 in r554746. Thanks!