Bug 245690 - x11-wm/herbstluftwm: Segfault on startx call after update to 0.8.0
Summary: x11-wm/herbstluftwm: Segfault on startx call after update to 0.8.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on: 245779
Blocks:
  Show dependency treegraph
 
Reported: 2020-04-17 11:04 UTC by Adam Jimerson
Modified: 2020-04-27 18:30 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (uzsolt)


Attachments
Fix segmentation fault (2.01 KB, patch)
2020-04-20 09:53 UTC, Zsolt Udvari
uzsolt: maintainer-approval+
Details | Diff
Official patch (1.75 KB, patch)
2020-04-20 10:20 UTC, Zsolt Udvari
uzsolt: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Jimerson 2020-04-17 11:04:32 UTC
After updating herbstluftwm to 0.8.0 it now segfaults when starting via `startx`.

I'm executing herbstluftwm like so in my $HOME/.xinitrc file:

exec herbstluftwm

I don't see anything in the output of startx to indicate an error other than the fact that Xorg failed to start and I see a core dump for herbstluftwm in my home directory. I can provide this core dump if needed, but I'll have to upload it somewhere is it's a 9.8 Mb file (too large to upload here).
Comment 1 Zsolt Udvari freebsd_committer freebsd_triage 2020-04-17 18:19:32 UTC
Indeed.

Could you share output of this method?
https://www.freebsd.org/doc/en/books/developers-handbook/debugging.html#idp45982584

gdb
(gdb) core herbstluftwm.core
(gdb) bt

I tried it but doesn't print functions only '???' (I'm not developer or gdb-expert).
Comment 3 Zsolt Udvari freebsd_committer freebsd_triage 2020-04-20 09:53:27 UTC
Created attachment 213596 [details]
Fix segmentation fault

Fix segmentation fault, based on https://lists.schokokeks.org/pipermail/hlwm/2020-April/000304.html

Tested, it works without segmentation fault.
Comment 4 Zsolt Udvari freebsd_committer freebsd_triage 2020-04-20 09:54:17 UTC
Should merge into quarterly too.
Comment 6 Zsolt Udvari freebsd_committer freebsd_triage 2020-04-20 10:11:47 UTC
Checking the github link. Please don't commit!
Comment 9 Adam Jimerson 2020-04-21 11:13:17 UTC
Sorry for the delayed response, I can confirm that the submitted patch does resolve the issue when applied and herbstluftwm is rebuilt with it.

One thing that threw me off is the patch seems to expect that the current working directory seems to be <Ports root>/x11-wm/herbstuftwm rather than directly in the ports root dir.
Comment 10 Zsolt Udvari freebsd_committer freebsd_triage 2020-04-21 11:17:32 UTC
(In reply to Adam Jimerson from comment #9)
The 0.8.1 is released with bugfixes - see above the report.

About patch: I'm using own script to maintain ports and I forgot overwrite the 'svn diff'. I'll do it :)
Comment 11 Tobias C. Berner freebsd_committer freebsd_triage 2020-04-25 17:45:29 UTC
(In reply to Zsolt Udvari from comment #10)
Moin moin 

So are you planning to simply upgrade to 0.8.1 or should the fix be committed first?

mfg Tobias
Comment 12 Zsolt Udvari freebsd_committer freebsd_triage 2020-04-25 17:54:26 UTC
(In reply to Tobias C. Berner from comment #11)
The 0.8.1 fixes this issue (I tried it). I think should close this report if 245779 is committed.
Comment 13 Zsolt Udvari freebsd_committer freebsd_triage 2020-04-27 05:15:15 UTC
Adam, the 0.8.1 works well?
Comment 14 Adam Jimerson 2020-04-27 13:26:39 UTC
The Official patch that is on this ticket, and is part of 0.8.1, is working fine, I have not rebuilt Herbstluftwm since the closure of issue bug #245779.

I'll manually upgrade my Herbstluftwm this evening to confirm, but it's probably safe to say this issue could be closed.
Comment 15 Adam Jimerson 2020-04-27 18:30:38 UTC
I successfully rebuilt Herbstluftwm from ports to update it to 0.8.1, and was able to reload the WM and start it via `startx` without issue.

I'll go ahead and close this issue marking it as fixed.