Created attachment 213561 [details]
make prints the following lines when building games/scummvm:
====> Running Q/A tests (stage-qa)
Error: /usr/local/bin/scummvm is linked to /usr/local/lib/liba52.so.0 from audio/liba52 but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=liba52.so:audio/liba52
Error: /usr/local/bin/scummvm is linked to /usr/local/lib/libcurl.so.4 from ftp/curl but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libcurl.so:ftp/curl
The attached diff adds the missing records to LIB_DEPENDS.
Comment on attachment 213561 [details]
Approved by: portmgr (blanket: ports compliance)
MFH: 2020Q2 (blanket: ports compliance)
Pending QA (perhaps these dependencies aren't necessary/expected, or can be made optional, or other changes to the patch would be needed)
(In reply to Kubilay Kocak from comment #1)
I noticed the "configure" script for SCUMMVM contains quite a lot of toggles to switch specific features ON and OFF. I'm not sure whether it's necessary to handle most/all of them, but I'd like to give it a go.
Created attachment 213655 [details]
I took a bit of liberty with this port:
- audio/liba52 is now an optional dependency and is by default ON (preserving existing functionality)
- ftp/libcurl is now an optional dependency and is by default OFF (does SCUMMVM require network support via cURL?)
- audio/libtremor was re-added as an optional dependency and is by default OFF (was previously disabled entirely)
ScummVM supports quite a lot of different audio, video and image formats, so it's hard to say which combination would be optimal for a good out-of-the-box experience.
As a side note, ScummVM 2.1.2 was released around a month ago so I'd like to update the port soon, but in a separate bug report.
Andy, thanks a lot for your patch!
I'll have a look at it later.
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/144524976