Bug 245741 - games/scummvm: Missing LIB_DEPENDS on audio/liba52 ftp/curl
Summary: games/scummvm: Missing LIB_DEPENDS on audio/liba52 ftp/curl
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Lars Engels
Keywords: buildisok, needs-qa
Depends on:
Reported: 2020-04-19 13:01 UTC by Andy Mender
Modified: 2020-05-11 03:04 UTC (History)
3 users (show)

See Also:
koobs: maintainer-feedback? (lme)
koobs: merge-quarterly?

Makefile diff (498 bytes, patch)
2020-04-19 13:01 UTC, Andy Mender
koobs: maintainer-approval+
Details | Diff
Makefile diff (2.20 KB, patch)
2020-04-21 22:13 UTC, Andy Mender
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Mender 2020-04-19 13:01:53 UTC
Created attachment 213561 [details]
Makefile diff

make prints the following lines when building games/scummvm:
====> Running Q/A tests (stage-qa)
Error: /usr/local/bin/scummvm is linked to /usr/local/lib/liba52.so.0 from audio/liba52 but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=liba52.so:audio/liba52
Error: /usr/local/bin/scummvm is linked to /usr/local/lib/libcurl.so.4 from ftp/curl but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libcurl.so:ftp/curl

The attached diff adds the missing records to LIB_DEPENDS.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2020-04-20 02:01:17 UTC
Comment on attachment 213561 [details]
Makefile diff

Approved by: portmgr (blanket: ports compliance)
MFH: 2020Q2 (blanket: ports compliance)

Pending QA (perhaps these dependencies aren't necessary/expected, or can be made optional, or other changes to the patch would be needed)
Comment 2 Andy Mender 2020-04-20 21:24:22 UTC
(In reply to Kubilay Kocak from comment #1)
I noticed the "configure" script for SCUMMVM contains quite a lot of toggles to switch specific features ON and OFF. I'm not sure whether it's necessary to handle most/all of them, but I'd like to give it a go.
Comment 3 Andy Mender 2020-04-21 22:13:10 UTC
Created attachment 213655 [details]
Makefile diff

I took a bit of liberty with this port:
- audio/liba52 is now an optional dependency and is by default ON (preserving existing functionality)

- ftp/libcurl is now an optional dependency and is by default OFF (does SCUMMVM require network support via cURL?)

- audio/libtremor was re-added as an optional dependency and is by default OFF (was previously disabled entirely)

ScummVM supports quite a lot of different audio, video and image formats, so it's hard to say which combination would be optimal for a good out-of-the-box experience.

As a side note, ScummVM 2.1.2 was released around a month ago so I'd like to update the port soon, but in a separate bug report.
Comment 4 Lars Engels freebsd_committer 2020-04-22 08:46:30 UTC
Andy, thanks a lot for your patch!

I'll have a look at it later.
Comment 5 Automation User 2020-05-11 03:04:21 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/144524976