Bug 246697 - bectl.c: sync help text to man page
Summary: bectl.c: sync help text to man page
Status: New
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2020-05-24 14:15 UTC by Jimmy Olgeni
Modified: 2020-05-30 19:54 UTC (History)
2 users (show)

See Also:


Attachments
bectl help text fixes (1.12 KB, patch)
2020-05-24 14:15 UTC, Jimmy Olgeni
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jimmy Olgeni freebsd_committer 2020-05-24 14:15:45 UTC
Created attachment 214812 [details]
bectl help text fixes

Sync the bectl help text with the man page synopsis.

Notably, the "-o" option of "bectl destroy" was missing.
Comment 1 Kyle Evans freebsd_committer 2020-05-30 19:54:32 UTC
Mostly LGTM -- there's one change that I don't think I agree with, but it's wrong in the manpage too (which is the version you changed it to):

> bectl jail [-bU] [{-o key=value | -u key}]...

-b and -U are mutually exclusive options, as they were represented before. We should also fix the manpage to reflect that (I can follow up with this) and perhaps make `bectl jail` actually error out. The problem is that the options are philosophically at odds with each other; one is specifically meant to keep the jail around and not do anything interactive with it because the caller will operate on it, while the other implies that the jail+mount should be torn down before bectl returns.