Created attachment 214818 [details]
Add a flavor for JSmol
JSmol, an HTML5-only web application, is included in the Jmol tarball, but the port does not install it.
Since it is needed for SageMath, the proposed patch make it install. To not change the actual port, this is done by a non-default flavor.
(In reply to Thierry Thomas from comment #0)
Portmgr, please approve flavors from this patch.
Created attachment 214888 [details]
Add a flavor for JSMOL
Fix a packaging problem with unzip.
Why not simply install it with the port?
You CANNOT write to STAGEDIR during build.
Also, this looks like you are trying to do subpackages with flavors, so this is a no.
(In reply to Mathieu Arnold from comment #3)
You mean, install it unconditionally with the original port?
Yes, just install the thing, I don't know how big it is, but it cannot be that bad.
Created attachment 214930 [details]
New patch to install JSmol with Jmol
As requested by mat@, this new patch lets the port install JSmol together with Jmol.
Thank you, Thierry, for adding JSmol.
I grouped your changes under a new port option JSMOL, so that it would be easy to make it into a subpackage once subpackages would become available.
A commit references this bug:
Date: Wed May 27 20:31:25 UTC 2020
New revision: 536715
science/jmol: Add JSmol (Java viewer for chemical structures in 3D) as a port option
Submitted by: thierry