Bug 246703 - science/jmol: install JSmol as a flavor
Summary: science/jmol: install JSmol as a flavor
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-24 18:38 UTC by Thierry Thomas
Modified: 2020-05-27 20:32 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (yuri)


Attachments
Add a flavor for JSmol (73.61 KB, patch)
2020-05-24 18:38 UTC, Thierry Thomas
no flags Details | Diff
Add a flavor for JSMOL (73.60 KB, patch)
2020-05-26 20:23 UTC, Thierry Thomas
no flags Details | Diff
New patch to install JSmol with Jmol (74.03 KB, patch)
2020-05-27 19:46 UTC, Thierry Thomas
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thierry Thomas freebsd_committer 2020-05-24 18:38:27 UTC
Created attachment 214818 [details]
Add a flavor for JSmol

JSmol, an HTML5-only web application, is included in the Jmol tarball, but the port does not install it.

Since it is needed for SageMath, the proposed patch make it install. To not change the actual port, this is done by a non-default flavor.
Comment 1 Yuri Victorovich freebsd_committer 2020-05-25 02:37:23 UTC
(In reply to Thierry Thomas from comment #0)

Thanks Thierry.

Portmgr, please approve flavors from this patch.

Thank you,
Yuri
Comment 2 Thierry Thomas freebsd_committer 2020-05-26 20:23:37 UTC
Created attachment 214888 [details]
Add a flavor for JSMOL

Fix a packaging problem with unzip.
Comment 3 Mathieu Arnold freebsd_committer 2020-05-27 08:44:18 UTC
Why not simply install it with the port?

You CANNOT write to STAGEDIR during build.
Comment 4 Mathieu Arnold freebsd_committer 2020-05-27 08:45:51 UTC
Also, this looks like you are trying to do subpackages with flavors, so this is a no.
Comment 5 Thierry Thomas freebsd_committer 2020-05-27 09:11:18 UTC
(In reply to Mathieu Arnold from comment #3)

You mean, install it unconditionally with the original port?
Comment 6 Mathieu Arnold freebsd_committer 2020-05-27 12:32:45 UTC
Yes, just install the thing, I don't know how big it is, but it cannot be that bad.
Comment 7 Thierry Thomas freebsd_committer 2020-05-27 19:46:30 UTC
Created attachment 214930 [details]
New patch to install JSmol with Jmol

As requested by mat@, this new patch lets the port install JSmol together with Jmol.
Comment 8 Yuri Victorovich freebsd_committer 2020-05-27 20:31:43 UTC
Thank you, Thierry, for adding JSmol.

I grouped your changes under a new port option JSMOL, so that it would be easy to make it into a subpackage once subpackages would become available.


Best,
Yuri
Comment 9 commit-hook freebsd_committer 2020-05-27 20:32:01 UTC
A commit references this bug:

Author: yuri
Date: Wed May 27 20:31:25 UTC 2020
New revision: 536715
URL: https://svnweb.freebsd.org/changeset/ports/536715

Log:
  science/jmol: Add JSmol (Java viewer for chemical structures in 3D) as a port option

  PR:		246703
  Submitted by:	thierry

Changes:
  head/science/jmol/Makefile
  head/science/jmol/pkg-descr
  head/science/jmol/pkg-plist-jsmol