Bug 246719 - devel/simavr: fix build on GCC architectures
Summary: devel/simavr: fix build on GCC architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-25 09:07 UTC by Piotr Kubaj
Modified: 2020-05-25 09:50 UTC (History)
1 user (show)

See Also:
zirias: maintainer-feedback+

Attachments
patch (1.02 KB, patch)
2020-05-25 09:07 UTC, Piotr Kubaj 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2020-05-25 09:07:24 UTC 
Created attachment 214839 [details]
patch

Merge the first hunk of https://github.com/buserror/simavr/commit/c2c8e40ff219f78779fc2743f0c1ffbabe159e37#diff-d06f1c6c1d6e380263f5450d5b70ca2b.diff to fix build. The whole patch can't be merged, the other two hunks don't apply.
Comment 1 Felix Palmen freebsd_committer freebsd_triage 2020-05-25 09:32:23 UTC 
Comment on attachment 214839 [details]
patch

Looks good (and also fixes a bug for any arch), thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-05-25 09:37:57 UTC 
A commit references this bug:

Author: pkubaj
Date: Mon May 25 09:37:17 UTC 2020
New revision: 536451
URL: https://svnweb.freebsd.org/changeset/ports/536451

Log:
  devel/simavr: fix build on GCC architectures

  Merge the first hunk of https://github.com/buserror/simavr/commit/c2c8e40ff219f78779fc2743f0c1ffbabe159e37#diff-d06f1c6c1d6e380263f5450d5b70ca2b.diff to fix build. The whole patch can't be merged, the other two hunks don't apply.

  PR:		246719
  Approved by:	felix@palmen-it.de (maintainer)

Changes:
  head/devel/simavr/files/patch-simavr_sim_run__avr.c
Comment 3 Felix Palmen freebsd_committer freebsd_triage 2020-05-25 09:41:02 UTC 
$ simavr -m fffffffffffffffffffffff
avr_make_mcu_by_name: AVR 'fffffffffffffffffffffff' not known
simavr: AVR 'fffffffffffffffffffffff' not known

$ simavr -m ffffffffffffffffffffffff
[1]    6849 segmentation fault  simavr -m ffffffffffffffffffffffff

The patch should fix this, I'll test. If so, should probably bump portrevision.
Comment 4 Felix Palmen freebsd_committer freebsd_triage 2020-05-25 09:45:58 UTC 
Yes, this segfault is fixed by the patch. Sorry for being late noticing this!