Bug 246767 - graphics/mesa-libs: enable libglvnd support
Summary: graphics/mesa-libs: enable libglvnd support
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-x11 (Nobody)
Keywords: needs-qa, patch
Depends on: 250739
Blocks: 251058
  Show dependency treegraph
Reported: 2020-05-27 07:49 UTC by Jan Beich
Modified: 2021-04-17 18:13 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (x11)
jbeich: exp-run+


Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2020-05-27 07:49:20 UTC
libglvnd abstracts away vendor-provided libGL. Currently, only Mesa and NVIDIA are supported. In future, multiple Mesa versions may co-exist.

See review D25020 for the patch.
Comment 1 Jan Beich freebsd_committer 2020-10-29 04:53:52 UTC
Can someone explain why exp-run hasn't been performed yet?
Comment 2 Antoine Brodin freebsd_committer 2020-10-29 06:58:53 UTC
(In reply to Jan Beich from comment #1)
According to the review the patch was not approved by maintainer.
Comment 3 Jan Beich freebsd_committer 2020-10-30 06:58:15 UTC
(In reply to Antoine Brodin from comment #2)
I'm disappointed in portmgr@ for facilitating the deadlock situation after x11@ said "it has to be thoroughly tested".
Comment 4 Kyle Evans freebsd_committer 2020-10-31 18:23:38 UTC
(In reply to Jan Beich from comment #3)

Existing deadlock aside, this seems like an odd stance to take. If I'm maintainer of something that's worth doing an exp-run for, I likely will not approve of a patch until I also see the consequences of the patch on reverse dependencies. i.e. maybe I approve in principle, but I want to see that due diligence is done before putting that on paper.

Antoine, do you have any numbers on how many exp-runs we end up not doing over some period of time because a maintainer doesn't approve of the patch?

I think it makes sense to revise this, because I can't imagine this is saving us all that much, resource-wise.
Comment 5 Antoine Brodin freebsd_committer 2020-10-31 21:39:53 UTC
(In reply to Kyle Evans from comment #4)

I don't want to waste an exp-run if x11@ is going to reject the patch even if the exp-run is successfull.   x11@ should speak up.
Comment 6 Jan Beich freebsd_committer 2021-01-30 11:10:40 UTC
Ping. I can't improve the patch or fix consumers without an exp-run.

x11@ actually did speak in favor years ago, see https://github.com/FreeBSDDesktop/freebsd-ports/commits/feature/libglvnd
Comment 7 Antoine Brodin freebsd_committer 2021-01-30 11:18:53 UTC
(In reply to Jan Beich from comment #6)
Can you refresh the patch?
Comment 9 Jan Beich freebsd_committer 2021-02-04 17:15:04 UTC
(In reply to Antoine Brodin from comment #8)
All fixed. Can you retry?
Comment 11 Jan Beich freebsd_committer 2021-02-11 14:15:16 UTC
(In reply to Antoine Brodin from comment #10)
Fixed. To find related commits see https://freshbsd.org/search?q=unbreak+libglvnd
Comment 12 Jan Beich freebsd_committer 2021-04-09 03:45:55 UTC
(In reply to Antoine Brodin from comment #10)
If exp-run is fine now, please, don't squat on Assignee field.