Bug 246855 - net/liboping: Make error handling *BSD friendly (EHOSTDOWN)
Summary: net/liboping: Make error handling *BSD friendly (EHOSTDOWN)
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
Keywords: buildisok, needs-qa
Depends on:
Reported: 2020-05-30 05:21 UTC by Chris Hutchinson
Modified: 2020-11-23 02:02 UTC (History)
3 users (show)

See Also:
portmaster: maintainer-feedback+
koobs: merge-quarterly?

add BSD friendly error handler (921 bytes, patch)
2020-05-30 05:21 UTC, Chris Hutchinson
portmaster: maintainer-approval+
Details | Diff
QA log for net/liboping (18.20 KB, text/plain)
2020-05-30 18:30 UTC, Chris Hutchinson
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Hutchinson 2020-05-30 05:21:37 UTC
Created attachment 215039 [details]
add BSD friendly error handler

Error handling in liboping isn't really BSD agnostic.
the patch attached to this pr(1) corrects that.
It simply adds EHOSTDOWN to the list on ARP/ND failure.
This addition was created by Gert Doering.
Builds/runs as intended on 13.0-CURRENT r358902 amd64

adds: files/patch-src_liboping.c

That's it.


Comment 1 Automation User 2020-05-30 05:37:27 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/151131600
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2020-05-30 08:34:07 UTC

- [tags] in issue Titles are deprecated
- maintainer-feedback flag is only required if set to ? first
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2020-05-30 08:34:55 UTC
@Maintainer Should this change be merged to the quarterly branch?
Comment 4 Chris Hutchinson 2020-05-30 17:51:56 UTC
(In reply to Kubilay Kocak from comment #3)
Yes, please. :-)

I'll try to keep all your thoughtful advise in mind
on future pr(1)s.

Thanks koobs! :-)

Comment 5 Chris Hutchinson 2020-05-30 18:30:23 UTC
Created attachment 215069 [details]
QA log for net/liboping

QA log for net/liboping to prove it builds/works
as intended -- no warns/errors.

Comment 6 Chris Hutchinson 2020-11-22 21:15:56 UTC
Can we please commit this? :-)

Comment 7 daniel.engberg.lists 2020-11-23 02:02:20 UTC
Perhaps bump it to latest release while at it?