Bug 246855 - net/liboping: Make error handling *BSD friendly (EHOSTDOWN)
Summary: net/liboping: Make error handling *BSD friendly (EHOSTDOWN)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dmitry Marakasov
URL:
Keywords: buildisok, needs-qa
Depends on:
Blocks:
 
Reported: 2020-05-30 05:21 UTC by Chris Hutchinson
Modified: 2021-03-19 23:01 UTC (History)
3 users (show)

See Also:
portmaster: maintainer-feedback+
koobs: merge-quarterly?

Attachments
add BSD friendly error handler (921 bytes, patch)
2020-05-30 05:21 UTC, Chris Hutchinson 		portmaster: maintainer-approval+
Details | Diff
QA log for net/liboping (18.20 KB, text/plain)
2020-05-30 18:30 UTC, Chris Hutchinson 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Hutchinson 2020-05-30 05:21:37 UTC 
Created attachment 215039 [details]
add BSD friendly error handler

Error handling in liboping isn't really BSD agnostic.
the patch attached to this pr(1) corrects that.
It simply adds EHOSTDOWN to the list on ARP/ND failure.
This addition was created by Gert Doering.
Builds/runs as intended on 13.0-CURRENT r358902 amd64

CHANGES
adds: files/patch-src_liboping.c

That's it.

Thanks!

--Chris
Comment 1 Automation User 2020-05-30 05:37:27 UTC 
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/151131600
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2020-05-30 08:34:07 UTC 
^Triage: 

- [tags] in issue Titles are deprecated
- maintainer-feedback flag is only required if set to ? first
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2020-05-30 08:34:55 UTC 
@Maintainer Should this change be merged to the quarterly branch?
Comment 4 Chris Hutchinson 2020-05-30 17:51:56 UTC 
(In reply to Kubilay Kocak from comment #3)
Yes, please. :-)

I'll try to keep all your thoughtful advise in mind
on future pr(1)s.

Thanks koobs! :-)

--Chris
Comment 5 Chris Hutchinson 2020-05-30 18:30:23 UTC 
Created attachment 215069 [details]
QA log for net/liboping

QA log for net/liboping to prove it builds/works
as intended -- no warns/errors.

--Chris
Comment 6 Chris Hutchinson 2020-11-22 21:15:56 UTC 
Can we please commit this? :-)

Thanks.
Comment 7 Daniel Engberg freebsd_committer freebsd_triage 2020-11-23 02:02:20 UTC 
Perhaps bump it to latest release while at it?
Comment 8 commit-hook freebsd_committer freebsd_triage 2021-03-19 23:01:58 UTC 
A commit references this bug:

Author: amdmi3
Date: Fri Mar 19 23:01:01 UTC 2021
New revision: 568816
URL: https://svnweb.freebsd.org/changeset/ports/568816

Log:
  - Implement proper handling for EHOSTDOWN on FreeBSD [1]
  - While here, fix license, WWWs and silence stripping

  PR:		246855
  Submitted by:	portmaster@bsdforge.com (maintainer)

Changes:
  head/net/liboping/Makefile
  head/net/liboping/files/
  head/net/liboping/files/patch-src_liboping.c