Bug 246861 - graphics/openimageio: Add PTEX option, Use external ptex port by default
Summary: graphics/openimageio: Add PTEX option, Use external ptex port by default
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: buildisok, needs-qa
Depends on:
Blocks:
 
Reported: 2020-05-30 08:33 UTC by Shane
Modified: 2020-05-30 10:55 UTC (History)
0 users

See Also:


Attachments
maintainer update for graphics/openimageio (2.23 KB, patch)
2020-05-30 08:33 UTC, Shane
FreeBSD: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shane 2020-05-30 08:33:53 UTC
Created attachment 215044 [details]
maintainer update for graphics/openimageio

adjust graphics/openimageio
Add PTEX option - on by default.
Previous versions included ptex source files, the project now uses external pre-built libraries instead.
Sort LIB_DEPENDS
Remove CONFLICTS, fbm port was removed some years ago.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2020-05-30 08:38:51 UTC
If its possible to pass (ptex) include/lib paths via CMAKE_* or other Makefile (MAKE_*, CONFIGURE_*, etc) variables, this is preferable to a source patch
Comment 2 Shane 2020-05-30 09:08:44 UTC
I do think it should be possible, but I couldn't get it to work, patching the search paths was the only way I could get it to find the include.

The problem falls into it not checking for existing variables, the PTEX_INCLUDE_DIR is always set using find_path(), overriding any passed values.

https://github.com/OpenImageIO/oiio/blob/master/src/cmake/modules/FindPTex.cmake

Also I install ptex headers into include/ptex while using include/wdas seems a more popular choice, that is what causes the existing search paths to fail, as even passing PTEX_LOCATION gets appended to, which ends up as /usr/local/include/wdas

While I could adjust ptex to use a wdas folder, the better option is to make the oiio search more flexible.
Comment 3 Automation User 2020-05-30 10:55:25 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/151149439