Bug 246885 - if_igb: Loader tunables/LEDs gone after iflib conversion?
Summary: if_igb: Loader tunables/LEDs gone after iflib conversion?
Status: New
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 12.1-RELEASE
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-net (Nobody)
URL:
Keywords: IntelNetworking, regression
Depends on:
Blocks:
 
Reported: 2020-05-30 22:48 UTC by Jose Luis Duran
Modified: 2020-08-29 01:09 UTC (History)
2 users (show)

See Also:


Attachments
em.4: Remove non-applicable sections (3.13 KB, patch)
2020-08-29 00:21 UTC, Jose Luis Duran
no flags Details | Diff
Remove LED-related sections (1.25 KB, patch)
2020-08-29 01:09 UTC, Jose Luis Duran
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jose Luis Duran 2020-05-30 22:48:09 UTC
if_igb(4) describe some hw.igb tunables (rxd, txd, enable_aim, num_queues).  I guess these were gone after iflib conversion.

Another side effect, I am not able to control the LEDs via led(4).

Tested on 12.1-RELEASE, device river i211.

Reference: base r223676, base r228788.
Comment 1 Jose Luis Duran 2020-05-30 23:44:06 UTC
Additional references: review D8299
Comment 2 Jeff Pieper 2020-05-31 12:56:23 UTC
Please see https://www.freebsd.org/cgi/man.cgi?query=iflib&sektion=4&manpath=freebsd-release-ports for a list of iflib sysctl variables.
Comment 3 Jose Luis Duran 2020-05-31 13:08:07 UTC
(In reply to Jeff Pieper from comment #2)

Does it mean that the section "LOADER TUNABLES" from if_igb(4) manual should be removed?
Comment 4 Kevin Bowling freebsd_committer 2020-08-28 23:40:35 UTC
(In reply to Jose Luis Duran from comment #3)
yes, can you submit a patch?
Comment 5 Jose Luis Duran 2020-08-29 00:21:21 UTC
Created attachment 217603 [details]
em.4: Remove non-applicable sections

Update manual to reflect current state.
Comment 6 Jose Luis Duran 2020-08-29 00:51:24 UTC
(In reply to Jose Luis Durhttps://bugs.freebsd.org/bugzilla/an from comment #5)

Wait... I think I have to create a separate igb.4/if_igb.4 man page (revert base r350075), because if_em do have these tunables.
Comment 7 Jose Luis Duran 2020-08-29 01:09:26 UTC
Created attachment 217604 [details]
Remove LED-related sections

Sorry, I was reading the on-line version of the man page and got confused.