Bug 247200 - graphics/mesa-dri: add NLS option
Summary: graphics/mesa-dri: add NLS option
Status: Closed Works As Intended
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-x11 (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2020-06-12 10:24 UTC by Jan Beich
Modified: 2020-06-16 20:50 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (x11)

Attachments
v1 (944 bytes, patch)
2020-06-12 10:24 UTC, Jan Beich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2020-06-12 10:24:00 UTC 
Created attachment 215480 [details]
v1

Since Mesa 19.1.0 upstream stopped bundling generated translations in src/util/xmlpool/options.h.

[6/1879] /usr/local/bin/python3.7 ../src/util/xmlpool/gen_xmlpool.py --template ../src/util/xmlpool/t_options.h --output src/util/xmlpool/options.h --localedir /wrkdirs/usr/ports/graphics/mesa-dri/work/mesa-19.0.8/_build/src/util/xmlpool --languages ca es de nl sv fr
Warning: language 'ca' not found.
Warning: language 'es' not found.
Warning: language 'de' not found.
Warning: language 'nl' not found.
Warning: language 'sv' not found.
Warning: language 'fr' not found.

$ fgrep -rl "Aktiviere sofortige Leerung des Stapelpuffers nach jedem Zeichenaufruf" /usr/local
/usr/local/lib/dri/i915_dri.so
/usr/local/lib/dri/i965_dri.so
/usr/local/lib/dri/radeon_dri.so
/usr/local/lib/dri/r200_dri.so
Comment 1 Emmanuel Vadot freebsd_committer freebsd_triage 2020-06-12 10:37:14 UTC 
LGTM
Comment 2 Niclas Zeising freebsd_committer freebsd_triage 2020-06-12 11:30:37 UTC 
There is no need to complicate mesa with this.  These translations are only used in a few places, and at least in 9.0.8 they are aready pre-generated, only the generation step is failing.  I see no reason for this change.

There are some info here: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5403

According to https://www.mesa3d.org/meson.html you also need to run three targets:
xmlpool-pot xmlpool-update-po xmlpool-gmo

If we really want the translations in a future update, we can revisit this.
Comment 3 Jan Beich freebsd_committer freebsd_triage 2020-06-16 18:58:37 UTC 
FWIW, upstream plans to drop translations, see https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5440
Comment 4 Niclas Zeising freebsd_committer freebsd_triage 2020-06-16 20:40:35 UTC 
(In reply to Jan Beich from comment #3)

Yes, Eric said that he was looking into that.  I'll close this, if this causes issues in the future, it's probably better to just pull in the upstream change removing the translations, or if the upstream translations are improved, we can make a new decision about including them then.
Comment 5 Niclas Zeising freebsd_committer freebsd_triage 2020-06-16 20:50:58 UTC 
Change to a more appropriate close reason.  There isn't any wontfix, so I picked works as intended, since it felt closest.