Bug 247429 - DESKTOPDIR set incorrectly
Summary: DESKTOPDIR set incorrectly
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-19 19:08 UTC by Mikhail Teterin
Modified: 2022-08-26 14:11 UTC (History)
1 user (show)

See Also:


Attachments
Base DESKTOPDIR on LOCALBASE instead of PREFIX (250 bytes, patch)
2020-06-19 19:08 UTC, Mikhail Teterin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Teterin freebsd_committer freebsd_triage 2020-06-19 19:08:19 UTC
Created attachment 215796 [details]
Base DESKTOPDIR on LOCALBASE instead of PREFIX

The knob is currently defined thus:

    DESKTOPDIR?=  ${PREFIX}/share/applications

which tells ports to install the DESKTOP_ENTRIES where the rest of the port is installed.

Instead, it probably should be:

    DESKTOPDIR?=  ${LOCALBASE}/share/applications

because, wherever a port installs its own bits, the desktop entries ought to be in the common location, where the desktop environments (KDE, Gnome, etc.) can find them.

That is, DESKTOPDIR is more like SED or LDCONFIG -- referring to an existing path, rather than, what the port will create.

The patch seems easy, but the discussion, probably, will not be...
Comment 1 Baptiste Daroussin freebsd_committer freebsd_triage 2022-08-26 14:11:05 UTC
That seems legit to me if the consumers only knows to look up for desktop files in localbase, if they can be configure to look elswhere then PREFIX is the right thing to use.

example manpath can be configured so the manpages are installed in MANPREFIX which respect PREFIX