Bug 247585 - textproc/py-pyjade: Remove TEST_DEPENDS
Summary: textproc/py-pyjade: Remove TEST_DEPENDS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL: https://github.com/syrusakbary/pyjade...
Depends on:
Blocks: 245309
  Show dependency treegraph
Reported: 2020-06-27 13:22 UTC by Kai Knoblich
Modified: 2020-06-29 16:18 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)

deprecate-py-pyjade.patch (625 bytes, patch)
2020-06-27 13:22 UTC, Kai Knoblich
no flags Details | Diff
py-pyjade-remove-TEST_DEPENDS.patch (798 bytes, patch)
2020-06-27 14:40 UTC, Kai Knoblich
kai: maintainer-approval? (sunpoet)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Knoblich freebsd_committer 2020-06-27 13:22:37 UTC
Created attachment 215982 [details]

Hi Sunpoet,

attached is the patch that deprecates textproc/py-pyjade and sets an expiration date for it.

The port seems to be broken at runtime (see also issue #277 at upstream repository) as it lacks compatibility with Django 1.11+:

> $ pyjade-3.7 
> Traceback (most recent call last):
>   File "/usr/local/bin/pyjade-3.7", line 11, in <module>
>     load_entry_point('pyjade==4.0.0', 'console_scripts', 'pyjade')()
>   File "/usr/local/lib/python3.7/site-packages/pyjade/convert.py", line 14, in convert_file
>     compiler_class = __import__('pyjade.ext.%s' % i, fromlist=['pyjade']).Compiler
>   File "/usr/local/lib/python3.7/site-packages/pyjade/ext/django/__init__.py", line 2, in <module>
>     from .compiler import Compiler
>   File "/usr/local/lib/python3.7/site-packages/pyjade/ext/django/compiler.py", line 92, in <module>
>     trans_real.templatize = decorate_templatize(trans_real.templatize)
> AttributeError: module 'django.utils.translation.trans_real' has no attribute 'templatize'
Comment 1 Kai Knoblich freebsd_committer 2020-06-27 14:40:34 UTC
Created attachment 215991 [details]

I overlooked that textproc/py-pyjade is still required as TEST_DEPENDS for devel/py-buildbot.

Attached is an updated patch that only removes the TEST_DEPENDS as the test-suite isn't used as there's no "do-test" target.
Comment 2 commit-hook freebsd_committer 2020-06-29 16:17:33 UTC
A commit references this bug:

Author: sunpoet
Date: Mon Jun 29 16:16:54 UTC 2020
New revision: 540803
URL: https://svnweb.freebsd.org/changeset/ports/540803


  PR:		247585
  Submitted by:	kai

Comment 3 Po-Chuan Hsieh freebsd_committer 2020-06-29 16:18:14 UTC
Committed. Thanks!