Bug 247627 - sysutils/py-salt: sysctl.present broken
Summary: sysutils/py-salt: sysctl.present broken
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2020-06-29 05:33 UTC by ari
Modified: 2020-06-30 13:08 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (christer.edwards)
koobs: merge-quarterly?


Attachments
Revert upstream PR that broke sysctl.persist on FreeBSD (12.40 KB, patch)
2020-06-29 21:32 UTC, Alan Somers
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ari 2020-06-29 05:33:48 UTC
https://github.com/saltstack/salt/issues/57826

Not sure the quickest way to hack a fix for this. Maybe adding a dummy param here:

https://github.com/saltstack/salt/blob/master/salt/modules/freebsd_sysctl.py#L138
Comment 1 Alan Somers freebsd_committer 2020-06-29 21:32:00 UTC
Created attachment 216049 [details]
Revert upstream PR that broke sysctl.persist on FreeBSD

Luckily, PR 55719 reverts cleanly, without any merge conflicts.  The attached patch completely reverts it from the port.  I tested it by applying state in my environment.
Comment 2 Kirill Ponomarev freebsd_committer 2020-06-30 05:47:26 UTC
Alan, thank you for submitting it, to be honest I don't see any reason to commit it right now as I'm going to revert this patch in upstream so new bugfix release will contain it pretty soon. What do you think?
Comment 3 Alan Somers freebsd_committer 2020-06-30 13:08:44 UTC
(In reply to Kirill Ponomarev from comment #2)
It's just a matter of timing; if you apply my patch Salt will work today.  If not, then we have to wait on upstream.