Bug 247947 - Consider trimming values passed to setenv in login.conf
Summary: Consider trimming values passed to setenv in login.conf
Status: New
Alias: None
Product: Base System
Classification: Unclassified
Component: conf (show other bugs)
Version: 12.1-STABLE
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-bugs (Nobody)
URL: https://reviews.freebsd.org/D25649
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-13 11:29 UTC by Michael Osipov
Modified: 2020-08-10 10:20 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Osipov 2020-07-13 11:29:01 UTC
Consider I want to write in login.conf:

default:\
    ...
    :setenv=BLOCKSIZE=K,\
        LSCOLORS=ExGxFxdxCxDxDxhbadExEx,\
        CLICOLOR=YES,\
        LESS=-x4 -R,\
        NCURSES_NO_UTF8_ACS=1,\
        EDITOR=vim:\
    ...

After cap_mkdb is run on /etc/login.conf and a relogin the indented env vars have preceding spaces and are unusable. While one can remove them, this breaks visual formatting and makes the file looks odd.

Consider trimming after splitting at the comma.
Comment 1 Michael Osipov 2020-07-13 21:47:39 UTC
Just applied the patch to 12-STABLE. The patch works for me decently.
Comment 2 Michael Osipov 2020-08-10 10:20:34 UTC
Anything holding off to apply this?