Created attachment 216575 [details] Patch Portscout flagged this port and since it has no maintainer, so here's an update to the latest version.
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/168282113
I'm not sure if an editor should install fonts. The noto fonts are already packaged too.
You're probably right. I'll remove the fonts from this package and make the Noto fonts a dependency.
Thank you Marcel! Would you be willing to maintain this port? If so, please update the MAINTAINER line to suit :)
However, it installs them into an application-specific folder and appears to need it internally. To bend the Noto fonts package to install there is probably harmful and to patch the editor is way out of scope for this version bump. I'll investigate when I find the time. Regarding maintainership: possibly. I am however not a regular user of the application so I cannot guarantee a quick turnaround. I've updated a couple of ports and by now I'm quite used to be asked to maintain it. ;) I'll consider any port I worked on, especially easy and older ones so they disappear from the "unmaintained" statistics.
Just found to time to verify: the application aborts if it doesn't find the fonts in /usr/local/share/cooledit/fonts. As stated before, patching to prevent this behavior is way out of scope. I don't think this is an issue. I'm also surprised to see that GCC9 gets installed wholesale automatically when USE_GCC is present, despite this application requiring it only for the build process. Is this expected behavior or something I could optimize? If I understand correctly, this is to be able to link against run-time libraries provided by GCC9. Please advise.
The behaviour of USE_GCC is expected however unless it's tested with 4.2.1 I'd suggest that it should be set to yes instead unless it compiles using clang. https://github.com/freebsd/freebsd-ports/blob/master/Mk/bsd.gcc.mk CPPFLAGS and LDFLAGS can most likely be replaced by localbase https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/uses-localbase.html Fonts should be patched to look in %%FONTSDIR%% instead along with properly added dependencies, bundled libraries and whatnot isn't the way to go unless it breaks the application. At least the python3 patch from OpenMandriva should be imported, possibly the linking patch too. https://github.com/OpenMandrivaAssociation/cooledit
There also seems to be a 4.0.1 patch provided by upstream https://www.ibiblio.org/pub/Linux/apps/editors/X/cooledit/cooledit-4.0.1.patch Sorry for not noticing.
I'm starting out with porting and this is just way too much, too fast for me. I understand the need for consistency but I cannot do more for this port. Feel free to take over or abandon this submission.
@Daniel Are you able and do you have cycles for an updated patch?
Created attachment 216674 [details] updated patch Here's a version which fixes a few things. It doesn't fix the font issue. When I ran the editor, it popped up an error on every character I typed. The error said "Error reading from ispell (or aspell). Ispell is being restarted." and I had to dismiss the error before I could type another character. I'd say we deprecate this unless there is personal interest in updating and maintaining it, it doesn't seem very popular: https://repology.org/project/cooledit/information
I had a discussion with swills@ on irc I agree with his conclusion. I have no personal interest in cooledit and there are multiple issues that needs to addressed on top of his patch. (Incomplete list) Makefile changes: DISTVERSION needs to be replaced with PORTVERSION= 4.0.1 MASTERSITES should only use https://www.ibiblio.org/pub/Linux/apps/editors/X/cooledit/ as the other mirrors are outdated and doesn't host tarball/archive. DISTNAME= ${PORTNAME}-${PORTVERSION:R}.0 needs to be added localbase should be added to USES and CPPFLAGS + LDFLAGS variables can be removed. It compiles with clang (13-CURRENT) so USE_GCC can probably be removed (no run test). CONFIGURE_ARGS= --with-x should be added Changes to upstream code: Related code for font path is in widget/font.c at L209-L218 however cooledit also seems to rely on two pcf fonts that it expects to be in the same dir which need further code fixes. Removing notosans from variable SUBDIRS in Makefile.in prevents installation of the fonts dir.
(In reply to daniel.engberg.lists from comment #12) Ok, thank you for the update. If the existing patch isn't ready, or work remains, can we - Add the port to WantedPorts, with a ("WIP patch") link to this issue - Close this Not Accepted This ensures that breadcrumbs are in place for people to easily find and pickup where it left off
Pass this on to new maintainer
Hello! I'm new port maintainer and I missed this PR. I'm working on this update to 4.0.1 that include patch: --- PORTNAME= cooledit DISTVERSION= 4.0.1 CATEGORIES= editors MASTER_SITES= SUNSITE/apps/editors/X/${PORTNAME} DISTNAME= cooledit-4.0.0 PATCH_SITES= ${MASTER_SITES} PATCHFILES= ${PORTNAME}-${DISTVERSION}.patch:-p1 --- And I switched from gcc to clang(c11). I need more tests and I'm waiting for new release tarball from author with more fixes like, e.g., NLS knob not working atm. Please wait a little more so I can test/talk with author. Please take a look at my Makefile: https://termbin.com/mtr2 Why did you remove Next_Look option? Thanks, Nuno Teixeira
And I'm working on Noto fonts
Nuno, Any progress on this? Your link also returns 404
(In reply to Daniel Engberg from comment #17) Hello Daniel, No progress at all related to Fonts and NLS that I was working with Cooledit author. I lost contact for several months now with him. I will put this port back to the pool. The problem that I found is that alot of things is hardcoded and I don't have skills to programming. The author told me that it will fix that in next version, but it becomes silent. I quit. Cheers, Nuno Teixeira
(In reply to Daniel Engberg from comment #17) "Your link also returns 404" what link?
(In reply to Nuno Teixeira from comment #19) "Please take a look at my Makefile: https://termbin.com/mtr2" - That one :/
(In reply to Daniel Engberg from comment #20) Thast not no longer available because to much time as passed. Like I said I quit from this port because I lost contact with author.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=83c11aa503a5191f4c338f9cd07ee3ad660d160c commit 83c11aa503a5191f4c338f9cd07ee3ad660d160c Author: Nuno Teixeira <eduardo@FreeBSD.org> AuthorDate: 2021-09-08 08:07:00 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2021-09-08 08:07:00 +0000 editors/cooledit: back port to pool Back port to pool. I've lost contact with project author and no solution found to update to a new version. PR: 248107 editors/cooledit/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
^Triage: closing and assigning to committer who resolved the issue.
Adjust CLOSED status as the update to proposed version did not happen.
(In reply to Alexey Dokuchaev from comment #24) Thanks for closing PR because I forgot it. Project have a new home at https://github.com/paulsheer/cooledit and I started to work on it at https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266918 Next version will solve the fonts problems and will have new features. Cheers