Bug 248426 - audio/ripit: Add DEPRECATED and EXPIRATION_DATE
Summary: audio/ripit: Add DEPRECATED and EXPIRATION_DATE
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Poul-Henning Kamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-02 10:36 UTC by Poul-Henning Kamp
Modified: 2020-08-24 02:55 UTC (History)
2 users (show)

See Also:
tobias.rehbein: maintainer-feedback+
koobs: merge-quarterly?


Attachments
Patch that deprecates audio/ripit (435 bytes, patch)
2020-08-23 19:42 UTC, tobias.rehbein
tobias.rehbein: maintainer-approval+
koobs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Poul-Henning Kamp freebsd_committer 2020-08-02 10:36:07 UTC
I think audio/ripit should be retired, it has been unmaintained for a decade and it has no support for HTTPS so it cannot retrieve CD metadata any longer.

audio/abcde is probably the logical successor
Comment 1 Fernando Apesteguía freebsd_committer 2020-08-05 05:33:28 UTC
^Triage: Reporter is committer, assign accordingly.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2020-08-05 13:53:45 UTC
@phk Happy to review/accept a patch so that you can commit and merge this
Comment 3 Poul-Henning Kamp freebsd_committer 2020-08-05 13:59:52 UTC
Ehhh.... I'm not actually a ports-committer, and I dont know all the strange customs and secret handshakes in ports-land...
Comment 4 tobias.rehbein 2020-08-23 19:41:10 UTC
(In reply to Poul-Henning Kamp from comment #0)
(In reply to Poul-Henning Kamp from comment #0)

Thanks for the report. I myself moved on to audio/abcde a long while ago, but tried  to keep this port alive, even after upstream disappeared years ago.

I just dusted off my CD drive and I have to admit, taht it seems to be the time to let it go.
Comment 5 tobias.rehbein 2020-08-23 19:42:26 UTC
Created attachment 217464 [details]
Patch that deprecates audio/ripit

The attached port adds DEPRECATED to the ports Makefile and I set EXPIRATION_DATE to 2020-11-01. This is the first time I am deprecating a port I am maintaining and therefore I am not sure, if I am expected to submit a patch removing the port in November, or if that happens automatically.
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2020-08-24 02:54:43 UTC
(In reply to Poul-Henning Kamp from comment #3)

No secret handshakes to speak of, just a QA'd patch that is reviewed by a ports committer

The current patch (attachment 217464 [details]) looks fine

If you're not comfortable merging it to the quarterly branch (/usr/ports/Tools/scripts/mfh 2020Q3 <revision>) just me know and I can take care of that for you.
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2020-08-24 02:55:04 UTC
Comment on attachment 217464 [details]
Patch that deprecates audio/ripit

Reviewed by: koobs (ports)
Approved by: koobs (ports)